Make IDBTransaction tasks asynchronous This is almost zero change in behavior for now, but makes it much easier to continue fleshing out an asynchronous layer between the frontend/backend and the backing store.
Created attachment 216632 [details] Patch v1
Comment on attachment 216632 [details] Patch v1 Attachment 216632 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/21249597
Comment on attachment 216632 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=216632&action=review > Source/WebCore/Modules/indexeddb/IDBCursorBackend.cpp:44 > +class CallbackCaller { I feel like there's a name for this. > Source/WebCore/Modules/indexeddb/IDBOperation.h:29 > +#include <Functional> capital F, really? > Source/WebCore/Modules/indexeddb/IDBTransactionBackend.cpp:245 > + // Take take a self reference to keep this object alive so that tasks can Take take > Source/WebCore/Modules/indexeddb/IDBTransactionBackend.cpp:254 > + { not sure if this belongs here or on the previous line. > Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:41 > +class CallbackCaller { déjà vu? > Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.cpp:382 > +void IDBDatabaseBackend::VersionChangeOperation::perform(std::function<void()> completionCallback) Wonder if your std::function deserves a typedef too.
Created attachment 216633 [details] Patch v2 - Whoops on the <Functional>
http://trac.webkit.org/changeset/159095