Bug 124182 – [WK2][EFL] Build break after r159088

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit EFL

[Ryuan Choi]

Since r159088, urlAtProcessExit() was removed.

I think that Efl port just use url as notification so that we'd better to remove this interface.

[Ryuan Choi]

Created attachment 216631 [details]
Patch

[Gyuyoung Kim]

Andersca, could you take a look this ?

[Gyuyoung Kim]

Comment on attachment 216631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216631&action=review

> Source/WebKit2/UIProcess/efl/ViewClientEfl.cpp:-87
> -        ewk_view_html_string_load(ewkView->evasObject(), "The web process has crashed.", 0, urlString);

I think it is helpful to report url which page is crashed. So, I don't know why andersca removed it.

[Csaba Osztrogonác]

+1 for reverting the unprofessional r159088 and let platforms report warning.

[Gyuyoung Kim]

r159088 is being reverted.

[Ryuan Choi]

Comment on attachment 216631 [details]
Patch

OK, I considered that it's minor if WK2 decide to remove it.

Revert is better for me, too.

Cleard flags.

[Csaba Osztrogonác]

(In reply to comment #4)
> +1 for reverting the unprofessional r159088 and let platforms report warning.

Sorry for the word "unprofessional", I didn't know if it isn't a political correct word for buggy/bad/wrong/mistake, I didn't want to hurt anybody. :(