Bug 124180 – GStreamer source files should be included in Windows build

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Alex Christensen]

I have a working concept of WinCairo with video enabled, and I'd like to get this to a point where it could be easily repeatably built.  Step 1 is to include the gstreamer files in the Windows build.  Step 2 will be to separate the ENABLE(VIDEO) from the USE(CA), and then we'll include some more code and do some fine polishing.

[Alex Christensen]

Created attachment 216630 [details]
Patch

[Philippe Normand]

Comment on attachment 216630 [details]
Patch

This looks good to me but I'll let Brent give the final review. Would be nice to have green win EWS too :)

[Brent Fulgham]

Comment on attachment 216630 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216630&action=review

This seems fine, but please exclude them from the Apple port build to reduce confusion.

> Source/WTF/WTF.vcxproj/WTF.vcxproj:78
> +    <ClCompile Include="..\wtf\gobject\GRefPtr.cpp" />

These need to be marked as "don't build" on non-WinCairo ports.

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:7261
> +    <ClCompile Include="..\platform\graphics\gstreamer\WebKitWebSourceGStreamer.cpp" />

These should be excluded as well.  I know that they don't compile due to the USE(GSTREAMER) guards, but it might confuse someone who thinks GStreamer is being used under the Apple port.

[Alex Christensen]

Created attachment 216713 [details]
Patch

[Brent Fulgham]

Comment on attachment 216713 [details]
Patch

r=me

[Alex Christensen]

http://trac.webkit.org/changeset/159146