Bug 124179 - Web Inspector: Remove some unused generated code
Summary: Web Inspector: Remove some unused generated code
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
Keywords: InRadar
Depends on:
Reported: 2013-11-11 19:49 PST by Joseph Pecoraro
Modified: 2013-11-11 20:37 PST (History)
5 users (show)

See Also:

[PATCH] Proposed Fix (3.32 KB, patch)
2013-11-11 19:51 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-11-11 19:49:28 PST
• InspectorBackendDispatcher::getCommandName is not used.
• InspectorFrontend::Foo classes never modify their InspectorFrontendChannel, so the getter/setter and null checks are unnecessary. Make m_inspectorFrontendChannel protected to avoid unused warning. This base class will go away.

This is just some prep for generating separate InspectorBackendDispatchers / InspectorFrontendDispatchers per domain. Start by removing some of the dead code not being converted / carried over.
Comment 1 Radar WebKit Bug Importer 2013-11-11 19:49:52 PST
Comment 2 Joseph Pecoraro 2013-11-11 19:51:18 PST
Created attachment 216629 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2013-11-11 20:37:52 PST
Comment on attachment 216629 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 216629

Committed r159093: <http://trac.webkit.org/changeset/159093>
Comment 4 WebKit Commit Bot 2013-11-11 20:37:54 PST
All reviewed patches have been landed.  Closing bug.