Bug 124178 – Start moving off of NSCalendarDate

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Ricky Mondello]

NSCalendarDate has been deprecated as of 10.6. WebKit should stop using it in favor of NSDate and NSDateComponents.

[Ricky Mondello]

Created attachment 216627 [details]
First attempt to run through EWS.

[Build Bot]

Comment on attachment 216627 [details]
First attempt to run through EWS.

Attachment 216627 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/22589461

[Ricky Mondello]

Created attachment 216628 [details]
Another attempt; might work for 10.8

[Build Bot]

Comment on attachment 216627 [details]
First attempt to run through EWS.

Attachment 216627 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/22369517

[Ricky Mondello]

Mark pointed out that my patch breaks the API contract (going as far as to explicitly edit a comment explaining it) of -[WebHistory orderedItemsLastVisitedOnDay:] and is therefore unacceptable. Specifically, `orderedItemsLastVisitedOnDay:` now takes an NSDate instead of an NSCalendarDate.

[Ricky Mondello]

Created attachment 216641 [details]
This time, don’t modify API.

[Conrad Shultz]

I'm not a reviewer, but the date math and API usage look correct to me.

[Anders Carlsson]

Comment on attachment 216641 [details]
This time, don’t modify API.

View in context: https://bugs.webkit.org/attachment.cgi?id=216641&action=review

> Source/WebKit/mac/History/WebHistory.h:131
> +#pragma clang diagnostic push
> +#pragma clang diagnostic ignored "-Wdeprecated-declarations"
>  - (NSArray *)orderedItemsLastVisitedOnDay:(NSCalendarDate *)calendarDate;
> +#pragma clang diagnostic pop

We can't disable deprecation warnings in public headers!

[Ricky Mondello]

Created attachment 216705 [details]
Use NS_DEPRECATED_MAC instead of #pragma-ing API and code supporting API

[Build Bot]

Comment on attachment 216705 [details]
Use NS_DEPRECATED_MAC instead of #pragma-ing API and code supporting API

Attachment 216705 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/22888797

[Build Bot]

Comment on attachment 216705 [details]
Use NS_DEPRECATED_MAC instead of #pragma-ing API and code supporting API

Attachment 216705 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/22369739

[Andy Estes]

Comment on attachment 216705 [details]
Use NS_DEPRECATED_MAC instead of #pragma-ing API and code supporting API

NSCalendarDate was also deprecated in iOS 7. Instead of using NS_DEPRECATED_MAC(10_4, 10_9), you should use NS_DEPRECATED(10_4, 10_9, 2_0, 7_0).

[Andy Estes]

<rdar://problem/15462774>

[Mark Rowe (bdash)]

Created attachment 217267 [details]
Disable the deprecation warnings

This change in WebHistory.h isn't ideal, but I'm really bored with having to work around this. We can remove it when we address bug 124189.

[WebKit Commit Bot]

Attachment 217267 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/History/WebHistory.h', u'Source/WebKit/mac/History/WebHistory.mm']" exit_code: 1
Source/WebKit/mac/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 217267 [details]
Disable the deprecation warnings

Clearing flags on attachment: 217267

Committed r159480: <http://trac.webkit.org/changeset/159480>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.