RESOLVED FIXED 124176
FrameFilter can just be an std::function instead 
https://bugs.webkit.org/show_bug.cgi?id=124176
Summary FrameFilter can just be an std::function instead
Anders Carlsson
Reported 2013-11-11 17:37:48 PST
FrameFilter can just be an std::function instead
Attachments
Patch (11.21 KB, patch)
2013-11-11 17:39 PST, Anders Carlsson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-11-11 17:39:15 PST
Created attachment 216626 [details] Patch
WebKit Commit Bot
Comment 2 2013-11-11 17:40:02 PST
Attachment 216626 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/DOM/WebDOMOperations.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp']" exit_code: 1 Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp:425: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp:499: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/loader/archive/cf/LegacyWebArchive.h:47: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/loader/archive/cf/LegacyWebArchive.h:61: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2013-11-11 17:49:36 PST
Committed r159089: <http://trac.webkit.org/changeset/159089>
Note You need to log in before you can comment on or make changes to this bug.