Bug 124169 - Remove ConstantFoldingPhase's weirdo compile-time optimization
Summary: Remove ConstantFoldingPhase's weirdo compile-time optimization
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Blocks: 124138
  Show dependency treegraph
Reported: 2013-11-11 14:55 PST by Filip Pizlo
Modified: 2013-11-11 15:00 PST (History)
7 users (show)

See Also:

the patch (2.98 KB, patch)
2013-11-11 14:57 PST, Filip Pizlo
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-11-11 14:55:27 PST
It's not needed anymore now that the compiler is concurrent - we're just not sensitive to such compile-time hacks anymore.
Comment 1 Filip Pizlo 2013-11-11 14:56:59 PST
This blocks https://bugs.webkit.org/show_bug.cgi?id=124138 because I'm pretty sure the fix to that requires making ConstantFoldingPhase do some special things for folded GetLocal's.  Currently it's already doing *really insane* special things for folded GetLocal's, and I don't want to put special things on top of special things.
Comment 2 Filip Pizlo 2013-11-11 14:57:51 PST
Created attachment 216615 [details]
the patch
Comment 3 Mark Hahnenberg 2013-11-11 14:58:44 PST
Comment on attachment 216615 [details]
the patch

r=me assuming benchmarks look good.
Comment 4 Filip Pizlo 2013-11-11 15:00:02 PST
Landed in http://trac.webkit.org/changeset/159074