RESOLVED FIXED 124169
Remove ConstantFoldingPhase's weirdo compile-time optimization 
https://bugs.webkit.org/show_bug.cgi?id=124169
Summary Remove ConstantFoldingPhase's weirdo compile-time optimization
Filip Pizlo
Reported 2013-11-11 14:55:27 PST
It's not needed anymore now that the compiler is concurrent - we're just not sensitive to such compile-time hacks anymore.
Attachments
the patch (2.98 KB, patch)
2013-11-11 14:57 PST, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-11-11 14:56:59 PST
This blocks https://bugs.webkit.org/show_bug.cgi?id=124138 because I'm pretty sure the fix to that requires making ConstantFoldingPhase do some special things for folded GetLocal's. Currently it's already doing *really insane* special things for folded GetLocal's, and I don't want to put special things on top of special things.
Filip Pizlo
Comment 2 2013-11-11 14:57:51 PST
Created attachment 216615 [details] the patch
Mark Hahnenberg
Comment 3 2013-11-11 14:58:44 PST
Comment on attachment 216615 [details] the patch r=me assuming benchmarks look good.
Filip Pizlo
Comment 4 2013-11-11 15:00:02 PST
Landed in http://trac.webkit.org/changeset/159074
Note You need to log in before you can comment on or make changes to this bug.