Bug 124166 - setupArguments needs 5 argument overload
Summary: setupArguments needs 5 argument overload
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 8
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-11 14:00 PST by Alex Christensen
Modified: 2013-12-16 19:45 PST (History)
8 users (show)

See Also:


Attachments
Patch (1.49 KB, patch)
2013-11-11 14:01 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (1.54 KB, patch)
2013-11-11 14:16 PST, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-11-11 14:00:16 PST
Compiling line 953 of Repatch.cpp fails on Win64 because there is no overload of setupArguments with 5 arguments.  I can't test it because the Win64 JIT is dead, but this makes it compile successfully.
Comment 1 Alex Christensen 2013-11-11 14:01:37 PST
Created attachment 216608 [details]
Patch
Comment 2 EFL EWS Bot 2013-11-11 14:05:36 PST
Comment on attachment 216608 [details]
Patch

Attachment 216608 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/22539452
Comment 3 Build Bot 2013-11-11 14:08:33 PST
Comment on attachment 216608 [details]
Patch

Attachment 216608 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/21249505
Comment 4 Alex Christensen 2013-11-11 14:16:56 PST
Created attachment 216612 [details]
Patch
Comment 5 Alex Christensen 2013-12-16 19:44:55 PST
This is no longer a problem