Bug 124165 - Remote Layer Tree: Implement Page Overlays
Summary: Remote Layer Tree: Implement Page Overlays
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-11-11 13:58 PST by Tim Horton
Modified: 2013-11-11 16:23 PST (History)
3 users (show)

See Also:


Attachments
patch (11.79 KB, patch)
2013-11-11 15:42 PST, Tim Horton
no flags Details | Formatted Diff | Diff
anders comments (11.73 KB, patch)
2013-11-11 15:53 PST, Tim Horton
andersca: review+
Details | Formatted Diff | Diff
for landing once SVN returns (11.36 KB, patch)
2013-11-11 16:11 PST, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-11-11 13:58:17 PST
Bring over page overlay functionality from TCADA.

<rdar://problem/15199056>
Comment 1 Tim Horton 2013-11-11 15:42:04 PST
Created attachment 216616 [details]
patch
Comment 2 Tim Horton 2013-11-11 15:53:02 PST
Created attachment 216617 [details]
anders comments
Comment 3 Anders Carlsson 2013-11-11 16:00:30 PST
Comment on attachment 216617 [details]
anders comments

View in context: https://bugs.webkit.org/attachment.cgi?id=216617&action=review

> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:78
> +    typedef HashMap<PageOverlay*, std::unique_ptr<GraphicsLayerCARemote>> PageOverlayLayerMap;
> +    PageOverlayLayerMap m_pageOverlayLayers;

No need for a typedef here.
Comment 4 Tim Horton 2013-11-11 16:11:12 PST
Created attachment 216620 [details]
for landing once SVN returns
Comment 5 Tim Horton 2013-11-11 16:23:20 PST
http://trac.webkit.org/changeset/159079