RESOLVED FIXED 124162
Win64 JavaScriptCore broken again 
https://bugs.webkit.org/show_bug.cgi?id=124162
Summary Win64 JavaScriptCore broken again
Alex Christensen
Reported 2013-11-11 12:58:01 PST
I disabled the JIT on Win64 a while ago, but there's another problem. After r158751, I get these compile errors: 6>..\jit\JITExceptions.cpp(52): error C2039: 'getCTIStub' : is not a member of 'JSC::VM' 6> C:\cygwin\webkit\Source\JavaScriptCore\runtime\VM.h(170) : see declaration of 'JSC::VM' 6>..\jit\JITExceptions.cpp(52): error C2065: 'throwNotCaught' : undeclared identifier 6>..\jit\JITExceptions.cpp(52): error C2228: left of '.code' must have class/struct/union 6>..\jit\JITExceptions.cpp(52): error C2228: left of '.executableAddress' must have class/struct/union I'm also not sure why it's surrounded by #if ENABLE(JIT) || ENABLE(LLINT) when we have this in Platform.h: #if !(ENABLE(JIT) || ENABLE(LLINT)) #error You have to have at least one execution model enabled to build JSC #endif What would be a good way to fix this problem? Should I implement either of these functions, or should I disable compiling some part of JavaScriptCore?
Attachments
Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2013-11-11 13:50:56 PST
(In reply to comment #0) > I disabled the JIT on Win64 a while ago, but there's another problem. After r158751, I get these compile errors: > > 6>..\jit\JITExceptions.cpp(52): error C2039: 'getCTIStub' : is not a member of 'JSC::VM' > 6> C:\cygwin\webkit\Source\JavaScriptCore\runtime\VM.h(170) : see declaration of 'JSC::VM' > 6>..\jit\JITExceptions.cpp(52): error C2065: 'throwNotCaught' : undeclared identifier > 6>..\jit\JITExceptions.cpp(52): error C2228: left of '.code' must have class/struct/union > 6>..\jit\JITExceptions.cpp(52): error C2228: left of '.executableAddress' must have class/struct/union > > I'm also not sure why it's surrounded by #if ENABLE(JIT) || ENABLE(LLINT) when we have this in Platform.h: > > #if !(ENABLE(JIT) || ENABLE(LLINT)) > #error You have to have at least one execution model enabled to build JSC > #endif > > What would be a good way to fix this problem? Should I implement either of these functions, or should I disable compiling some part of JavaScriptCore? I'm working on a fix for this. Right now, you can't build without ENABLE(JIT).
Alex Christensen
Comment 2 2013-12-16 19:43:53 PST
This is no longer a problem. Win64 JavaScriptCore compiles fine
Note You need to log in before you can comment on or make changes to this bug.