Bug 124158 - End of line whitespace should collapse with white-space:pre-wrap; overflow-wrap:break-word in all cases
Summary: End of line whitespace should collapse with white-space:pre-wrap; overflow-wr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-11 11:15 PST by Antti Koivisto
Modified: 2014-01-13 08:59 PST (History)
6 users (show)

See Also:

Attachments
patch (277.01 KB, patch)
2013-11-11 11:32 PST, Antti Koivisto 		hyatt: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (1.10 MB, application/zip)
2013-11-11 12:23 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (1017.22 KB, application/zip)
2013-11-11 13:07 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-11-11 11:15:30 PST 
If a word just fits the line but the following space overflows we fail to collapse whitespaces at the end of the line.
Comment 1 Antti Koivisto 2013-11-11 11:32:43 PST 
Created attachment 216592 [details]
patch
Comment 2 WebKit Commit Bot 2013-11-11 11:34:52 PST 
Attachment 216592 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/text/break-word-pre-wrap-expected.html', u'LayoutTests/fast/text/break-word-pre-wrap.html', u'LayoutTests/platform/mac/fast/forms/basic-textareas-expected.png', u'LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt', u'LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.png', u'LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp']" exit_code: 1
LayoutTests/ChangeLog:14:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2013-11-11 11:35:57 PST 
Comment on attachment 216592 [details]
patch

r=me
Comment 4 Dave Hyatt 2013-11-11 11:36:10 PST 
Comment on attachment 216592 [details]
patch

r=me
Comment 5 Build Bot 2013-11-11 12:23:21 PST 
Comment on attachment 216592 [details]
patch

Attachment 216592 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/22938215

New failing tests:
fast/forms/basic-textareas-quirks.html
js/basic-set.html
fast/forms/basic-textareas.html
Comment 6 Build Bot 2013-11-11 12:23:23 PST 
Created attachment 216596 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Build Bot 2013-11-11 13:07:19 PST 
Comment on attachment 216592 [details]
patch

Attachment 216592 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/22938228

New failing tests:
fast/forms/basic-textareas-quirks.html
compositing/tiling/tiled-in-iframe.html
fast/forms/basic-textareas.html
Comment 8 Build Bot 2013-11-11 13:07:21 PST 
Created attachment 216604 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 9 Antti Koivisto 2013-11-11 15:19:44 PST 
https://trac.webkit.org/r159071 (with sl baselines)
Comment 10 Ryosuke Niwa 2014-01-13 08:59:49 PST 
Closing the bug as the patch for this bug has been committed in http://trac.webkit.org/changeset/159071.