Bug 124152 – Fix undefined reference issues in JavaScriptCore build.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Balazs Kilvady]

These errors come up when building GTK port of jsc with gcc 4.7.2.
Linking CXX executable ../../../bin/jsc
../../../lib/libjavascriptcoregtk.a(SymbolTable.cpp.o): In function `JSC::SharedSymbolTable::destroy(JSC::JSCell*)':
SymbolTable.cpp:(.text._ZN3JSC17SharedSymbolTable7destroyEPNS_6JSCellE+0x44): undefined reference to `JSC::JSCell::inherits(JSC::ClassInfo const*) const'

../../../lib/libjavascriptcoregtk.a(SymbolTable.cpp.o): In function `JSC::SharedSymbolTable::destroy(JSC::JSCell*)':
SymbolTable.cpp:(.text._ZN3JSC17SharedSymbolTable7destroyEPNS_6JSCellE+0x44): undefined reference to `JSC::JSCell::classInfo() const'

[Balazs Kilvady]

Created attachment 216580 [details]
proposed patch.

[kov's GTK+ EWS bot]

Comment on attachment 216580 [details]
proposed patch.

Attachment 216580 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/22938190

[Zan Dobersek]

Comment on attachment 216580 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=216580&action=review

> Source/JavaScriptCore/runtime/SymbolTable.cpp:33
> +#include "JSCellInlines.h"
> +#include "JSDestructibleObject.h"

Additionally include the SlotVisitorInlines.h header to get rid of the new undefined reference that was exposed by the GTK EWS.

I think after that the patch will be good to go into the tree.

[Balazs Kilvady]

Created attachment 216649 [details]
fixed patch.

SlotVisitorInlines.h added, thanks to Zan Dobersek. Rebased on 159100.

[WebKit Commit Bot]

Comment on attachment 216649 [details]
fixed patch.

Clearing flags on attachment: 216649

Committed r159116: <http://trac.webkit.org/changeset/159116>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.