Bug 124144 – [GTK] Update GTK builders in Tools/Scripts/webkitpy/port/builders.py

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Denis Nomiyama (dnomi)]

The list of GTK builders in Tools/Scripts/webkitpy/port/builders.py does not match the actual names in http://build.webkit.org/builders.

[Denis Nomiyama (dnomi)]

Created attachment 216561 [details]
Patch

[Mario Sanchez Prada]

Comment on attachment 216561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216561&action=review

> Tools/Scripts/webkitpy/port/builders.py:71
>      "GTK Linux 64-bit Debug": {"port_name": "gtk", "is_debug": True},

This one's name is now "GTK Linux 64-bit Debug WK1". What about updating it too?

[Denis Nomiyama (dnomi)]

(In reply to comment #2)
> (From update of attachment 216561 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=216561&action=review
> > Tools/Scripts/webkitpy/port/builders.py:71
> >      "GTK Linux 64-bit Debug": {"port_name": "gtk", "is_debug": True},
> This one's name is now "GTK Linux 64-bit Debug WK1". What about updating it too?

Sure, I'll update the patch.

[Denis Nomiyama (dnomi)]

Created attachment 216564 [details]
Patch

[Mario Sanchez Prada]

Comment on attachment 216564 [details]
Patch

Looks good to me, but I'd rather have someone more familiar with the python magic taking a look to it, in case we might be missing something.

[Gustavo Noronha (kov)]

Comment on attachment 216564 [details]
Patch

LGTM!

[Denis Nomiyama (dnomi)]

(In reply to comment #6)
> (From update of attachment 216564 [details])
> LGTM!

Great! Thanks Gustavo.

[WebKit Commit Bot]

Comment on attachment 216564 [details]
Patch

Rejecting attachment 216564 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 216564, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/git.webkit.org/WebKit
   d2d6baf..9b6223e  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 159100 = d2d6baf839adc8e58564459b2aacd6c6d5b0e753
r159101 = 9b6223e3c25de7f39b567bb175b3e3ec4ad85e03
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/22539597

[Mario Sanchez Prada]

Comment on attachment 216564 [details]
Patch

Let's give this another try now that SVN auth seems to be working fine again

[WebKit Commit Bot]

Comment on attachment 216564 [details]
Patch

Clearing flags on attachment: 216564

Committed r159109: <http://trac.webkit.org/changeset/159109>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Tim Horton]

I think this broke a webkitpy test: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20(Tests)/builds/13504/steps/webkitpy-test/logs/stdio

Looking into it.

[Tim Horton]

(In reply to comment #12)
> I think this broke a webkitpy test: http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20(Tests)/builds/13504/steps/webkitpy-test/logs/stdio
> 
> Looking into it.

Theoretically fixed in http://trac.webkit.org/changeset/159130. Do you guys not have any WK2 testers anymore?

[Gustavo Noronha (kov)]

Thanks Tim, sorry for the trouble! Our 64 bits release bot is also a tester and it runs the wk2 tests. I think it may be a good idea to split the tests to help see build failures more easily, since our bot ends up being red most of the time because of layout tests being added that we don't pass or the like.