Bug 124140 - Do not shut down ImageDiff server after every diff during the tests.
Summary: Do not shut down ImageDiff server after every diff during the tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-11 01:39 PST by Tamas Gergely
Modified: 2013-11-11 09:31 PST (History)
3 users (show)

See Also:


Attachments
Do not shut down ImageDiff server after every diff during the tests. (1.29 KB, patch)
2013-11-11 01:47 PST, Tamas Gergely
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tamas Gergely 2013-11-11 01:39:59 PST
There is a FIXME in image_diff.py: There is no need to shut down the ImageDiff server after every diff.
Comment 1 Tamas Gergely 2013-11-11 01:47:16 PST
Created attachment 216552 [details]
Do not shut down ImageDiff server after every diff during the tests.
Comment 2 WebKit Commit Bot 2013-11-11 03:42:59 PST
Comment on attachment 216552 [details]
Do not shut down ImageDiff server after every diff during the tests.

Rejecting attachment 216552 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 216552, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
t.org/repository/webkit/trunk ...
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Password for 'commit-queue@webkit.org': 
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Username: Use of uninitialized value $username in chomp at /usr/share/git-core/perl/Git/SVN/Prompt.pm line 114.
error: git-svn died of signal 11

Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.appspot.com/results/22938116
Comment 3 Csaba Osztrogonác 2013-11-11 03:49:09 PST
It seems svn.webkit.org has some issue, I tried and wasn't able to land it manually. I sent a mail to wms and bdash about the problem.
Comment 4 WebKit Commit Bot 2013-11-11 09:31:13 PST
Comment on attachment 216552 [details]
Do not shut down ImageDiff server after every diff during the tests.

Clearing flags on attachment: 216552

Committed r159051: <http://trac.webkit.org/changeset/159051>
Comment 5 WebKit Commit Bot 2013-11-11 09:31:15 PST
All reviewed patches have been landed.  Closing bug.