WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
124131
[EFL] Build break on Ubuntu 13.10
https://bugs.webkit.org/show_bug.cgi?id=124131
Summary
[EFL] Build break on Ubuntu 13.10
Ryuan Choi
Reported
2013-11-10 19:05:59 PST
I got below errors on ubuntu 13.10. In file included from /home/ryuan/workspace/project/webkit/efl-webkit/Source/ThirdParty/gtest/include/gtest/gtest.h:57:0, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.h:24, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp:20: /home/ryuan/workspace/project/webkit/efl-webkit/Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h: In function ‘const char* testing::internal::SkipComma(const char*)’: /home/ryuan/workspace/project/webkit/efl-webkit/Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:650:28: error: ‘isspace_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h’ was not declared in this scope while (isspace(*(++comma))) {} ^ /home/ryuan/workspace/project/webkit/efl-webkit/Source/ThirdParty/gtest/include/gtest/internal/gtest-internal.h:650:28: note: suggested alternative: In file included from /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebCore/config.h:80:0, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp:19: /home/ryuan/workspace/project/webkit/efl-webkit/Source/WTF/wtf/DisallowCType.h:75:17: note: ‘std::isspace_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h’ #define isspace isspace_WTF_Please_use_ASCIICType_instead_of_ctype_see_comment_in_ASCIICType_h ^ make[2]: *** [Source/WebKit/CMakeFiles/ewkTestUtils.dir/efl/tests/UnitTestUtils/EWKTestEnvironment.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs....
Attachments
Patch
(1.25 KB, patch)
2013-11-10 19:24 PST
,
Ryuan Choi
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryuan Choi
Comment 1
2013-11-10 19:24:44 PST
Created
attachment 216542
[details]
Patch
Gyuyoung Kim
Comment 2
2013-11-10 20:26:16 PST
Comment on
attachment 216542
[details]
Patch Looks OK, But, isn't this better ? !(OS(DARWIN) && PLATFORM(GTK) && PLATFORM(EFL))
Ryuan Choi
Comment 3
2013-11-10 20:29:00 PST
(In reply to
comment #2
)
> (From update of
attachment 216542
[details]
) > Looks OK, But, isn't this better ? > !(OS(DARWIN) && PLATFORM(GTK) && PLATFORM(EFL))
No, We are not based on OS(DARWIN). :)
Gyuyoung Kim
Comment 4
2013-11-10 20:30:43 PST
Comment on
attachment 216542
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=216542&action=review
> Source/WTF/wtf/DisallowCType.h:44 > +#if !(OS(DARWIN) && PLATFORM(GTK)) && !OS(QNX) && !PLATFORM(EFL) && !defined(_LIBCPP_VERSION)
Ah, you're right. I mistook this condition. Go ahead !
WebKit Commit Bot
Comment 5
2013-11-10 20:56:41 PST
Comment on
attachment 216542
[details]
Patch Clearing flags on attachment: 216542 Committed
r159037
: <
http://trac.webkit.org/changeset/159037
>
WebKit Commit Bot
Comment 6
2013-11-10 20:56:44 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug