Bug 124125 – Remove all 'std' using directives from WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Remove all 'std' using directives from WebCore

[Anders Carlsson]

Created attachment 216529 [details]
Patch

[Sam Weinig]

Comment on attachment 216529 [details]
Patch

rs=me

[WebKit Commit Bot]

Attachment 216529 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/loader/CrossOriginPreflightResultCache.cpp', u'Source/WebCore/loader/WorkerThreadableLoader.cpp', u'Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp', u'Source/WebCore/loader/appcache/ManifestParser.cpp', u'Source/WebCore/loader/cache/MemoryCache.cpp', u'Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/DOMTimer.cpp', u'Source/WebCore/page/FocusController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/PageGroupLoadDeferrer.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/animation/AnimationBase.cpp', u'Source/WebCore/page/animation/KeyframeAnimation.cpp', u'Source/WebCore/platform/DateComponents.cpp', u'Source/WebCore/platform/ScrollAnimator.cpp', u'Source/WebCore/platform/ScrollView.cpp', u'Source/WebCore/platform/Scrollbar.cpp', u'Source/WebCore/platform/ScrollbarThemeComposite.cpp', u'Source/WebCore/platform/SharedBuffer.cpp', u'Source/WebCore/platform/ThreadTimers.cpp', u'Source/WebCore/platform/Timer.cpp', u'Source/WebCore/platform/URL.cpp', u'Source/WebCore/platform/audio/AudioResampler.cpp', u'Source/WebCore/platform/audio/AudioResamplerKernel.cpp', u'Source/WebCore/platform/audio/Distance.cpp', u'Source/WebCore/platform/audio/DynamicsCompressorKernel.cpp', u'Source/WebCore/platform/audio/EqualPowerPanner.cpp', u'Source/WebCore/platform/audio/HRTFDatabase.cpp', u'Source/WebCore/platform/audio/HRTFElevation.cpp', u'Source/WebCore/platform/audio/HRTFKernel.cpp', u'Source/WebCore/platform/audio/HRTFPanner.cpp', u'Source/WebCore/platform/audio/Reverb.cpp', u'Source/WebCore/platform/audio/SincResampler.cpp', u'Source/WebCore/platform/cf/URLCF.cpp', u'Source/WebCore/platform/graphics/Color.cpp', u'Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp', u'Source/WebCore/platform/graphics/FloatQuad.cpp', u'Source/WebCore/platform/graphics/FloatSize.cpp', u'Source/WebCore/platform/graphics/FontFastPath.cpp', u'Source/WebCore/platform/graphics/FontPlatformData.cpp', u'Source/WebCore/platform/graphics/GraphicsContext.cpp', u'Source/WebCore/platform/graphics/RoundedRect.cpp', u'Source/WebCore/platform/graphics/ShadowBlur.cpp', u'Source/WebCore/platform/graphics/SimpleFontData.cpp', u'Source/WebCore/platform/graphics/WidthIterator.cpp', u'Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp', u'Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm', u'Source/WebCore/platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm', u'Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp', u'Source/WebCore/platform/graphics/ca/mac/TileController.mm', u'Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageBufferDataCG.cpp', u'Source/WebCore/platform/graphics/cg/ImageSourceCG.cpp', u'Source/WebCore/platform/graphics/filters/FEDropShadow.cpp', u'Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp', u'Source/WebCore/platform/graphics/gpu/Texture.cpp', u'Source/WebCore/platform/graphics/gpu/TilingData.cpp', u'Source/WebCore/platform/graphics/mac/ComplexTextController.cpp', u'Source/WebCore/platform/graphics/mac/FontComplexTextMac.cpp', u'Source/WebCore/platform/graphics/mac/FontMac.mm', u'Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm', u'Source/WebCore/platform/graphics/mac/SimpleFontDataMac.mm', u'Source/WebCore/platform/graphics/transforms/Matrix3DTransformOperation.cpp', u'Source/WebCore/platform/graphics/transforms/MatrixTransformOperation.cpp', u'Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.cpp', u'Source/WebCore/platform/graphics/transforms/RotateTransformOperation.cpp', u'Source/WebCore/platform/graphics/transforms/TransformOperations.cpp', u'Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp', u'Source/WebCore/platform/mac/ScrollAnimatorMac.mm', u'Source/WebCore/platform/mac/ScrollViewMac.mm', u'Source/WebCore/platform/mac/ScrollbarThemeMac.mm', u'Source/WebCore/platform/mac/ThemeMac.mm', u'Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm', u'Source/WebCore/platform/network/HTTPHeaderMap.cpp', u'Source/WebCore/platform/network/ResourceRequestBase.cpp', u'Source/WebCore/platform/network/ResourceResponseBase.cpp', u'Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp', u'Source/WebCore/platform/network/mac/ResourceResponseMac.mm', u'Source/WebCore/platform/text/TextBreakIteratorICU.cpp', u'Source/WebCore/platform/text/TextCodecUTF16.cpp', u'Source/WebCore/platform/text/TextCodecUTF8.cpp', u'Source/WebCore/platform/text/TextStream.cpp', u'Source/WebCore/platform/text/mac/LocaleMac.mm', u'Source/WebCore/platform/text/mac/TextCodecMac.cpp', u'Source/WebCore/rendering/AutoTableLayout.cpp', u'Source/WebCore/rendering/FixedTableLayout.cpp', u'Source/WebCore/rendering/FloatingObjects.cpp', u'Source/WebCore/rendering/InlineBox.cpp', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/InlineTextBox.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerModelObject.cpp', u'Source/WebCore/rendering/RenderLineBoxList.cpp', u'Source/WebCore/rendering/RenderListBox.cpp', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderMarquee.cpp', u'Source/WebCore/rendering/RenderMediaControls.cpp', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderMeter.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnSet.cpp', u'Source/WebCore/rendering/RenderNamedFlowFragment.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderReplaced.cpp', u'Source/WebCore/rendering/RenderRubyBase.cpp', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderRubyText.cpp', u'Source/WebCore/rendering/RenderScrollbarPart.cpp', u'Source/WebCore/rendering/RenderSearchField.cpp', u'Source/WebCore/rendering/RenderTable.cpp', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControlSingleLine.cpp', u'Source/WebCore/rendering/RenderThemeMac.mm', u'Source/WebCore/rendering/RenderWidget.cpp', u'Source/WebCore/rendering/RootInlineBox.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp', u'Source/WebCore/rendering/style/RenderStyle.cpp', u'Source/WebCore/rendering/style/SVGRenderStyle.cpp', u'Source/WebCore/rendering/style/ShadowData.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp', u'Source/WebCore/rendering/svg/RenderSVGRoot.cpp', u'Source/WebCore/rendering/svg/SVGInlineFlowBox.cpp', u'Source/WebCore/rendering/svg/SVGInlineTextBox.cpp', u'Source/WebCore/svg/SVGAnimatedNumber.cpp', u'Source/WebCore/svg/SVGAnimatedNumberOptionalNumber.cpp', u'Source/WebCore/svg/animation/SMILTimeContainer.cpp', u'Source/WebCore/svg/animation/SVGSMILElement.cpp', u'Source/WebCore/xml/XMLTreeViewer.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp']" exit_code: 1
Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:690:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderLayer.cpp:2593:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderLayer.cpp:2594:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderObject.cpp:910:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderObject.cpp:913:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderObject.cpp:918:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderObject.cpp:921:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderObject.cpp:926:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderObject.cpp:929:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderObject.cpp:934:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderObject.cpp:937:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/RenderMarquee.cpp:143:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/ScrollView.cpp:258:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 13 in 102 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Committed r159027: <http://trac.webkit.org/changeset/159027>

[EFL EWS Bot]

Comment on attachment 216529 [details]
Patch

Attachment 216529 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/22779082

[Csaba Osztrogonác]

(In reply to comment #4)
> Committed r159027: <http://trac.webkit.org/changeset/159027>

Just to have a backlog, buildfixes landed in
- https://trac.webkit.org/changeset/159028
- https://trac.webkit.org/changeset/159029
- https://trac.webkit.org/changeset/159050