Bug 124124 - Reduce the size of RenderBlockFlow by making its rare data inherit from RenderBlockRareData
Summary: Reduce the size of RenderBlockFlow by making its rare data inherit from Rende...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-10 09:57 PST by Sam Weinig
Modified: 2013-11-11 08:56 PST (History)
5 users (show)

See Also:


Attachments
Patch (17.91 KB, patch)
2013-11-10 09:59 PST, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff
another (32.62 KB, patch)
2013-11-10 11:32 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-11-10 09:57:57 PST
Reduce the size of RenderBlockFlow by making its rare data inherit from RenderBlockRareData
Comment 1 Sam Weinig 2013-11-10 09:59:04 PST
Created attachment 216527 [details]
Patch
Comment 2 Antti Koivisto 2013-11-10 11:27:20 PST
Comment on attachment 216527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216527&action=review

> Source/WebCore/rendering/RenderBlockFlow.h:96
> -    struct RenderBlockFlowRareData {
> +    struct RenderBlockFlowRareData : public RenderBlockRareData {

I think most RenderBlocks are RenderBlockFlows. Just smashing these together might be ok too.
Comment 3 Antti Koivisto 2013-11-10 11:32:51 PST
Created attachment 216530 [details]
another
Comment 4 Antti Koivisto 2013-11-10 11:33:20 PST
Comment on attachment 216530 [details]
another

Uh wrong bug
Comment 5 Sam Weinig 2013-11-10 16:20:31 PST
Committed r159034: <http://trac.webkit.org/changeset/159034>
Comment 6 Andreas Kling 2013-11-10 22:12:48 PST
Comment on attachment 216527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216527&action=review

>> Source/WebCore/rendering/RenderBlockFlow.h:96
>> +    struct RenderBlockFlowRareData : public RenderBlockRareData {
> 
> I think most RenderBlocks are RenderBlockFlows. Just smashing these together might be ok too.

Yeh. Then we also don't need to have a vtable for RenderBlockRareData.
Comment 7 Dave Hyatt 2013-11-11 08:56:46 PST
I think there was a better way to do this, since you're paying 4 bytes in RenderBlock when RenderBlock's rare data will almost never be allocated. Could have just made a hash for RenderBlock's rare data. I did this without realizing this patch had landed and now have a bunch of conflicts. :)