Reduce the size of RenderBlockFlow by making its rare data inherit from RenderBlockRareData
Created attachment 216527 [details] Patch
Comment on attachment 216527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216527&action=review > Source/WebCore/rendering/RenderBlockFlow.h:96 > - struct RenderBlockFlowRareData { > + struct RenderBlockFlowRareData : public RenderBlockRareData { I think most RenderBlocks are RenderBlockFlows. Just smashing these together might be ok too.
Created attachment 216530 [details] another
Comment on attachment 216530 [details] another Uh wrong bug
Committed r159034: <http://trac.webkit.org/changeset/159034>
Comment on attachment 216527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216527&action=review >> Source/WebCore/rendering/RenderBlockFlow.h:96 >> + struct RenderBlockFlowRareData : public RenderBlockRareData { > > I think most RenderBlocks are RenderBlockFlows. Just smashing these together might be ok too. Yeh. Then we also don't need to have a vtable for RenderBlockRareData.
I think there was a better way to do this, since you're paying 4 bytes in RenderBlock when RenderBlock's rare data will almost never be allocated. Could have just made a hash for RenderBlock's rare data. I did this without realizing this patch had landed and now have a bunch of conflicts. :)