Bug 124097 - Updating LayoutTests that depend on RTCPeerConnection
Summary: Updating LayoutTests that depend on RTCPeerConnection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago de Barros Lacerda
URL:
Keywords:
Depends on: 124095
Blocks: 124288
  Show dependency tree / graph
 
Reported: 2013-11-08 19:36 PST by Thiago de Barros Lacerda
Modified: 2014-05-19 09:08 PDT (History)
6 users (show)

See Also:

Attachments
Patch (10.04 KB, patch)
2013-11-08 19:39 PST, Thiago de Barros Lacerda 		eric.carlson: review+
eric.carlson: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (10.04 KB, patch)
2013-11-08 20:21 PST, Thiago de Barros Lacerda 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago de Barros Lacerda 2013-11-08 19:36:58 PST 
Needed to do not throw unwanted exception
Comment 1 Thiago de Barros Lacerda 2013-11-08 19:39:31 PST 
Created attachment 216478 [details]
Patch
Comment 2 Eric Carlson 2013-11-08 19:49:44 PST 
Comment on attachment 216478 [details]
Patch

It looks like this patch needs to be rebased.
Comment 3 Eric Carlson 2013-11-08 19:52:08 PST 
(In reply to comment #2)
> (From update of attachment 216478 [details])
> It looks like this patch needs to be rebased.

Maybe it depends on bug 124095?
Comment 4 Thiago de Barros Lacerda 2013-11-08 19:56:07 PST 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 216478 [details] [details])
> > It looks like this patch needs to be rebased.
> 
> Maybe it depends on bug 124095?

Yes, it depends on 124095. I've added it as a dependency already. Let's wait for the other to get in
Comment 5 Thiago de Barros Lacerda 2013-11-08 20:21:06 PST 
Created attachment 216480 [details]
Patch for landing
Comment 6 Thiago de Barros Lacerda 2013-11-08 20:21:55 PST 
(In reply to comment #5)
> Created an attachment (id=216480) [details]
> Patch for landing

Forgot to pass --no-review :(
Comment 7 WebKit Commit Bot 2013-11-08 21:58:49 PST 
Comment on attachment 216480 [details]
Patch for landing

Clearing flags on attachment: 216480

Committed r158991: <http://trac.webkit.org/changeset/158991>