Bug 124084 - getCueAsHTML() on an empty cue should return a document fragment
Summary: getCueAsHTML() on an empty cue should return a document fragment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-08 16:40 PST by Eric Carlson
Modified: 2013-11-08 17:12 PST (History)
5 users (show)

See Also:

Attachments
Proposed patch (4.34 KB, patch)
2013-11-08 16:47 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-11-08 16:40:07 PST 
A cue with no text should return a valid document fragment
Comment 1 Eric Carlson 2013-11-08 16:47:26 PST 
Created attachment 216463 [details]
Proposed patch
Comment 2 Darin Adler 2013-11-08 16:56:37 PST 
Comment on attachment 216463 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216463&action=review

> Source/WebCore/html/track/WebVTTParser.cpp:356
> +    if (!text.length()) {

Normally we’d use isEmpty here instead.
Comment 3 Eric Carlson 2013-11-08 17:11:48 PST 
(In reply to comment #2)
> (From update of attachment 216463 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=216463&action=review
> 
> > Source/WebCore/html/track/WebVTTParser.cpp:356
> > +    if (!text.length()) {
> 
> Normally we’d use isEmpty here instead.

Good point, fixed.
Comment 4 Eric Carlson 2013-11-08 17:12:14 PST 
Committed r158979: https://trac.webkit.org/r158979