Bug 124072 - Web Inspector: remove -webkit-min and -webkit-max from CSS completions
Summary: Web Inspector: remove -webkit-min and -webkit-max from CSS completions
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
Keywords: InRadar
Depends on:
Reported: 2013-11-08 14:06 PST by Joseph Pecoraro
Modified: 2013-11-08 15:45 PST (History)
8 users (show)

See Also:

[PATCH] Proposed Fix (10.73 KB, patch)
2013-11-08 14:12 PST, Joseph Pecoraro
timothy: review+
Details | Formatted Diff | Diff
[PATCH] Fixed ChangeLog (10.74 KB, patch)
2013-11-08 15:11 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-11-08 14:06:30 PST
It looks like these were at one point added to the CSS parser but have no real implementation and were removed from the related CSS 3 spec.

Note that Web Inspector includes completions for these functions which should also be removed if they are unimplemented:


CSS Values and Units Module Level 3 - 9/6/2011 - had min() and max()

CSS Values and Units Module Level 3 - 7/30/2013 - doesn't have them:

They may be re-introduced in Values and Units 4:
"min() and max() were deferred due to concerns about defining behavior in shrinkwrap cases. If we can figure this out, we should put them back in Level 4."
Comment 1 Radar WebKit Bug Importer 2013-11-08 14:06:49 PST
Comment 2 Joseph Pecoraro 2013-11-08 14:12:13 PST
Created attachment 216438 [details]
[PATCH] Proposed Fix
Comment 3 Vicki Pfau 2013-11-08 14:14:11 PST
Comment on attachment 216438 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=216438&action=review

> Source/WebInspectorUI/ChangeLog:8
> +        -webkit-min and -webkit-max are implemented in WebCore, despite mentions of it.

nit: You appear to have left out a negative here
Comment 4 Joseph Pecoraro 2013-11-08 15:11:06 PST
Created attachment 216447 [details]
[PATCH] Fixed ChangeLog
Comment 5 WebKit Commit Bot 2013-11-08 15:45:16 PST
Comment on attachment 216447 [details]
[PATCH] Fixed ChangeLog

Clearing flags on attachment: 216447

Committed r158966: <http://trac.webkit.org/changeset/158966>
Comment 6 WebKit Commit Bot 2013-11-08 15:45:18 PST
All reviewed patches have been landed.  Closing bug.