Bug 124072 – Web Inspector: remove -webkit-min and -webkit-max from CSS completions

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

It looks like these were at one point added to the CSS parser but have no real implementation and were removed from the related CSS 3 spec.

Note that Web Inspector includes completions for these functions which should also be removed if they are unimplemented:
<http://trac.webkit.org/browser/trunk/Source/WebInspectorUI/UserInterface/CSSKeywordCompletions.js>

---

CSS Values and Units Module Level 3 - 9/6/2011 - had min() and max()
<http://www.w3.org/TR/2011/WD-css3-values-20110906/#calc>

CSS Values and Units Module Level 3 - 7/30/2013 - doesn't have them:
<http://www.w3.org/TR/css3-values/>

They may be re-introduced in Values and Units 4:
<http://www.w3.org/Style/CSS/Tracker/issues/203>
"min() and max() were deferred due to concerns about defining behavior in shrinkwrap cases. If we can figure this out, we should put them back in Level 4."

[Radar WebKit Bug Importer]

<rdar://problem/15427989>

[Joseph Pecoraro]

Created attachment 216438 [details]
[PATCH] Proposed Fix

[Vicki Pfau]

Comment on attachment 216438 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=216438&action=review

> Source/WebInspectorUI/ChangeLog:8
> +        -webkit-min and -webkit-max are implemented in WebCore, despite mentions of it.

nit: You appear to have left out a negative here

[Joseph Pecoraro]

Created attachment 216447 [details]
[PATCH] Fixed ChangeLog

[WebKit Commit Bot]

Comment on attachment 216447 [details]
[PATCH] Fixed ChangeLog

Clearing flags on attachment: 216447

Committed r158966: <http://trac.webkit.org/changeset/158966>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.