Bug 124068 - Merge IDBCursorBackendInterface and IDBCursorBackendImpl
Summary: Merge IDBCursorBackendInterface and IDBCursorBackendImpl
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
Depends on:
Reported: 2013-11-08 13:41 PST by Brady Eidson
Modified: 2013-11-08 15:15 PST (History)
5 users (show)

See Also:

Patch v1 (72.14 KB, patch)
2013-11-08 14:10 PST, Brady Eidson
andersca: review+
Details | Formatted Diff | Diff
Updated patch for EWS (71.18 KB, patch)
2013-11-08 14:28 PST, Brady Eidson
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-11-08 13:41:57 PST
Merge IDBCursorBackendInterface and IDBCursorBackendImpl

No need for the abstraction anymore.
Comment 1 Brady Eidson 2013-11-08 14:10:26 PST
Created attachment 216437 [details]
Patch v1
Comment 2 Brady Eidson 2013-11-08 14:27:15 PST
Thanks for the review - I'll rebase and run the updated patch by EWS before landing
Comment 3 Brady Eidson 2013-11-08 14:28:23 PST
Created attachment 216440 [details]
Updated patch for EWS
Comment 4 WebKit Commit Bot 2013-11-08 14:36:12 PST
Comment on attachment 216440 [details]
Updated patch for EWS

Rejecting attachment 216440 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 216440, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/22508620
Comment 5 Brady Eidson 2013-11-08 14:47:05 PST
Comment 6 Brady Eidson 2013-11-08 15:15:10 PST
Windows build fix followup in http://trac.webkit.org/changeset/158961