WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
12406
addMessageToConsole should work without a Page
https://bugs.webkit.org/show_bug.cgi?id=12406
Summary
addMessageToConsole should work without a Page
Alexey Proskuryakov
Reported
2007-01-25 10:30:16 PST
In many cases, error messages may not get logged, because there is no frame or page to call addMessageToConsole() on, e.g.: void SVGDocumentExtensions::reportWarning(const String& message) { if (Page* page = m_doc->frame()->page()) page->chrome()->addMessageToConsole("Warning: " + message, m_doc->tokenizer() ? m_doc->tokenizer()->lineNumber() : 1, String()); } It would be good to find a way not to lose these messages.
Attachments
Add attachment
proposed patch, testcase, etc.
Ahmad Saleem
Comment 1
2022-07-13 00:33:46 PDT
This line is changed now:
https://github.com/WebKit/WebKit/blob/0393f2f7c7a1e97a7a4c63441b50703cc11d493f/Source/WebCore/svg/SVGDocumentExtensions.cpp#L134
ap@webkit.org
- is it something still need to be fixed?
Alexey Proskuryakov
Comment 2
2022-07-13 18:17:08 PDT
I'm not sure. But if it hasn't been done in 15 years, keeping this bug open won't get it done.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug