Bug 124046 - [WebGL] Removing unnecessary pointer checks
Summary: [WebGL] Removing unnecessary pointer checks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-11-08 08:04 PST by Przemyslaw Szymanski
Modified: 2014-01-10 10:19 PST (History)
8 users (show)

See Also:

Attachments
glbuffer (1.70 KB, patch)
2013-11-08 08:09 PST, Przemyslaw Szymanski 		bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Przemyslaw Szymanski 2013-11-08 08:04:37 PST 
When an array pointer is check with 0 it is not necessary to check it again
Comment 1 Przemyslaw Szymanski 2013-11-08 08:09:26 PST 
Created attachment 216399 [details]
glbuffer
Comment 2 Brent Fulgham 2013-11-19 17:39:37 PST 
Comment on attachment 216399 [details]
glbuffer

View in context: https://bugs.webkit.org/attachment.cgi?id=216399&action=review

True!  Thanks for catching this. Can you revise the ChangeLog slightly per my comments?

> Source/WebCore/ChangeLog:8
> +        Pointer to array member can be check only once. It is not need

The log message is a little incorrect.  I think it should read:

"The array argument does not need to checked for NULL more than once."
Comment 3 Brent Fulgham 2014-01-10 10:12:22 PST 
Comment on attachment 216399 [details]
glbuffer

r=me. I'll correct the change log while landing.
Comment 4 Radar WebKit Bug Importer 2014-01-10 10:16:13 PST 
<rdar://problem/15793235>
Comment 5 Brent Fulgham 2014-01-10 10:19:00 PST 
Committed r161649: <http://trac.webkit.org/changeset/161649>