RESOLVED FIXED 124030
Update an out-dated ASSERT in IconDatabase code 
https://bugs.webkit.org/show_bug.cgi?id=124030
Summary Update an out-dated ASSERT in IconDatabase code
Brady Eidson
Reported 2013-11-07 21:19:33 PST
Update an out-dated ASSERT in IconDatabase code The ASSERT in IconDatabase.cpp: ASSERT(iconRecord || m_retainedPageURLs.contains(pageURLOriginal)); ... was added when the IconDatabase interface was largely synchronous and only about WebKit1 With the asynchronous interfaces that have been added and the support for WK2 that has been added, the ASSERT can incorrectly fire if an icon is asked for before database cleanup is allowed. It should be updated to: ASSERT(iconRecord || databaseCleanupCounter || m_retainedPageURLs.contains(pageURLOriginal)); In radar as <rdar://problem/15171118>
Attachments
Patch v1 (1.87 KB, patch)
2013-11-07 21:25 PST, Brady Eidson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2013-11-07 21:25:09 PST
Created attachment 216359 [details] Patch v1
Andreas Kling
Comment 2 2013-11-07 21:25:45 PST
Comment on attachment 216359 [details] Patch v1 rs=me
Brady Eidson
Comment 3 2013-11-07 21:38:40 PST
http://trac.webkit.org/changeset/158904
Note You need to log in before you can comment on or make changes to this bug.