Bug 124018 - Enhance SQL journal_mode setting code to be less likely to log an error
Summary: Enhance SQL journal_mode setting code to be less likely to log an error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-11-07 15:42 PST by Brady Eidson
Modified: 2013-11-07 22:06 PST (History)
1 user (show)

See Also:

Attachments
Patch v1 (2.04 KB, patch)
2013-11-07 15:44 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2013-11-07 15:42:01 PST 
Enhance SQL journal_mode setting code to be less likely to log an error

Even though the docs says SQLITE_ROW will always be returned, apparently SQLITE_OK is sometimes returned.  Change the code to handle that.
Comment 1 Brady Eidson 2013-11-07 15:43:47 PST 
In radar as <rdar://problem/15418577>
Comment 2 Brady Eidson 2013-11-07 15:44:07 PST 
Created attachment 216339 [details]
Patch v1
Comment 3 WebKit Commit Bot 2013-11-07 22:06:45 PST 
Comment on attachment 216339 [details]
Patch v1 

Clearing flags on attachment: 216339

Committed r158906: <http://trac.webkit.org/changeset/158906>
Comment 4 WebKit Commit Bot 2013-11-07 22:06:47 PST 
All reviewed patches have been landed.  Closing bug.