Bug 124000 – [GTK] Add new GTK-specific layout test results for vertical text

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Denis Nomiyama (dnomi)]

The following layout tests are failing on the GTK+ buildbots because they require specific GTK+ expected results.

fast/repaint/japanese-rl-selection-clear.html
fast/repaint/japanese-rl-selection-repaint.html
fast/repaint/repaint-across-writing-mode-boundary.html
fast/text/international/vertical-text-glyph-test.html
fast/text/justify-ideograph-vertical.html

[Denis Nomiyama (dnomi)]

Created attachment 216316 [details]
Patch

Patch with GTK+ expected results.

[Denis Nomiyama (dnomi)]

Hi Mario,
Can you please have a look at this patch?
These new expected results for GTK+ were supposed to be in my patch in Bug 50619, but I think I forgot to git-add them.. Sorry about that.
Thank you.

[Mario Sanchez Prada]

Comment on attachment 216316 [details]
Patch

(In reply to comment #2)
> Hi Mario,
> Can you please have a look at this patch?
> These new expected results for GTK+ were supposed to be in my patch in Bug 50619, but I think I forgot to git-add them.. Sorry about that.

Ah! That explains the thing, then. Thanks for taking care of creating these new ones then.

[Mario Sanchez Prada]

Comment on attachment 216316 [details]
Patch

I just realized by locally running webkit-patch rebaseline, that there is a more efficient way to do this, as the optimization step shows.

Denis, would you mind regenerating this patch by using that command instead of doing it manually?

Thanks

[Denis Nomiyama (dnomi)]

(In reply to comment #4)
> (From update of attachment 216316 [details])
> I just realized by locally running webkit-patch rebaseline, that there is a more efficient way to do this, as the optimization step shows.
> 
> Denis, would you mind regenerating this patch by using that command instead of doing it manually?
> 
> Thanks

Sure, no problem.
During the optimisation I noticed that these tests have specific results for WebKit2 GTK+ because WebKit1 has a permanent area in the bottom for the horizontal scroll bar.
This area reduces the layout area in WebKit1 and consequently the
results differ from WebKit2.

[Denis Nomiyama (dnomi)]

Created attachment 216370 [details]
Patch

Modified patch according to Mario's suggestion.

[Mario Sanchez Prada]

Comment on attachment 216370 [details]
Patch

That looks better. Thanks!

[WebKit Commit Bot]

Comment on attachment 216370 [details]
Patch

Clearing flags on attachment: 216370

Committed r158919: <http://trac.webkit.org/changeset/158919>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.