Bug 124000 - [GTK] Add new GTK-specific layout test results for vertical text
Summary: [GTK] Add new GTK-specific layout test results for vertical text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-07 10:33 PST by Denis Nomiyama (dnomi)
Modified: 2013-11-08 06:40 PST (History)
6 users (show)

See Also:


Attachments
Patch (19.73 KB, patch)
2013-11-07 11:06 PST, Denis Nomiyama (dnomi)
no flags Details | Formatted Diff | Diff
Patch (70.78 KB, patch)
2013-11-08 03:36 PST, Denis Nomiyama (dnomi)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Nomiyama (dnomi) 2013-11-07 10:33:04 PST
The following layout tests are failing on the GTK+ buildbots because they require specific GTK+ expected results.

fast/repaint/japanese-rl-selection-clear.html
fast/repaint/japanese-rl-selection-repaint.html
fast/repaint/repaint-across-writing-mode-boundary.html
fast/text/international/vertical-text-glyph-test.html
fast/text/justify-ideograph-vertical.html
Comment 1 Denis Nomiyama (dnomi) 2013-11-07 11:06:35 PST
Created attachment 216316 [details]
Patch

Patch with GTK+ expected results.
Comment 2 Denis Nomiyama (dnomi) 2013-11-08 01:28:36 PST
Hi Mario,
Can you please have a look at this patch?
These new expected results for GTK+ were supposed to be in my patch in Bug 50619, but I think I forgot to git-add them.. Sorry about that.
Thank you.
Comment 3 Mario Sanchez Prada 2013-11-08 02:12:28 PST
Comment on attachment 216316 [details]
Patch

(In reply to comment #2)
> Hi Mario,
> Can you please have a look at this patch?
> These new expected results for GTK+ were supposed to be in my patch in Bug 50619, but I think I forgot to git-add them.. Sorry about that.

Ah! That explains the thing, then. Thanks for taking care of creating these new ones then.
Comment 4 Mario Sanchez Prada 2013-11-08 02:18:27 PST
Comment on attachment 216316 [details]
Patch

I just realized by locally running webkit-patch rebaseline, that there is a more efficient way to do this, as the optimization step shows.

Denis, would you mind regenerating this patch by using that command instead of doing it manually?

Thanks
Comment 5 Denis Nomiyama (dnomi) 2013-11-08 03:32:52 PST
(In reply to comment #4)
> (From update of attachment 216316 [details])
> I just realized by locally running webkit-patch rebaseline, that there is a more efficient way to do this, as the optimization step shows.
> 
> Denis, would you mind regenerating this patch by using that command instead of doing it manually?
> 
> Thanks

Sure, no problem.
During the optimisation I noticed that these tests have specific results for WebKit2 GTK+ because WebKit1 has a permanent area in the bottom for the horizontal scroll bar.
This area reduces the layout area in WebKit1 and consequently the
results differ from WebKit2.
Comment 6 Denis Nomiyama (dnomi) 2013-11-08 03:36:03 PST
Created attachment 216370 [details]
Patch

Modified patch according to Mario's suggestion.
Comment 7 Mario Sanchez Prada 2013-11-08 06:15:25 PST
Comment on attachment 216370 [details]
Patch

That looks better. Thanks!
Comment 8 WebKit Commit Bot 2013-11-08 06:40:22 PST
Comment on attachment 216370 [details]
Patch

Clearing flags on attachment: 216370

Committed r158919: <http://trac.webkit.org/changeset/158919>
Comment 9 WebKit Commit Bot 2013-11-08 06:40:26 PST
All reviewed patches have been landed.  Closing bug.