RESOLVED FIXED 123998
Remove unneeded moving of ESP to ECX in callToJavaScript for COMPILER(MSVC) 
https://bugs.webkit.org/show_bug.cgi?id=123998
Summary Remove unneeded moving of ESP to ECX in callToJavaScript for COMPILER(MSVC)
Michael Saboff
Reported 2013-11-07 10:07:05 PST
In trac.webkit.org/changeset/37406, we added __fastcall support to CTI runtime calls. It was there that we copied ESP to ECX in ctiTrampoline as the first argument to the called function. ctiTrampoline is now callToJavaScript thunk. Upon entry to a function, we trash ECX, when we use it to save the returnPC. All arguments to called JavaScript are in the argument slots of the call frame. I'm not sure when we no longer needed , but it can be removed now.
Attachments
Patch (1.39 KB, patch)
2013-11-07 10:16 PST, Michael Saboff 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2013-11-07 10:16:54 PST
Created attachment 216312 [details] Patch
Mark Lam
Comment 2 2013-11-07 10:24:22 PST
Comment on attachment 216312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216312&action=review r=me with comment fixed. > Source/JavaScriptCore/ChangeLog:9 > + funciton is no longer needed. "funciton" ==> "function"
Michael Saboff
Comment 3 2013-11-07 11:21:31 PST
Committed r158857: <http://trac.webkit.org/changeset/158857>
Note You need to log in before you can comment on or make changes to this bug.