Bug 123993 - Region based multicol: support explicit column breaks
Summary: Region based multicol: support explicit column breaks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Morten Stenshorne
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-07 07:44 PST by Morten Stenshorne
Modified: 2014-01-20 11:51 PST (History)
7 users (show)

See Also:

Attachments
Test case (1.21 KB, text/html)
2013-11-07 07:58 PST, Morten Stenshorne 		no flags Details
Patch (47.28 KB, patch)
2014-01-14 01:28 PST, Morten Stenshorne 		no flags Details | Formatted Diff | Diff
Patch (47.28 KB, patch)
2014-01-14 01:48 PST, Morten Stenshorne 		no flags Details | Formatted Diff | Diff
Patch (47.31 KB, patch)
2014-01-20 00:59 PST, Morten Stenshorne 		no flags Details | Formatted Diff | Diff
Patch (47.31 KB, patch)
2014-01-20 01:16 PST, Morten Stenshorne 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Morten Stenshorne 2013-11-07 07:44:51 PST 
Explicit column breaks are currently not supported in the region based multicol implementation.

Apart from simply making the implementation support it at all (which is trivial), we also have to make the column balancer aware of explicit breaks, which is a bit more work.
Comment 1 Morten Stenshorne 2013-11-07 07:58:12 PST 
Created attachment 216302 [details]
Test case
Comment 2 Morten Stenshorne 2014-01-14 01:28:56 PST 
Created attachment 221122 [details]
Patch
Comment 3 Build Bot 2014-01-14 01:35:39 PST 
Comment on attachment 221122 [details]
Patch

Attachment 221122 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6094733210288128
Comment 4 Morten Stenshorne 2014-01-14 01:48:28 PST 
Created attachment 221126 [details]
Patch
Comment 5 Dave Hyatt 2014-01-17 11:41:14 PST 
Comment on attachment 221126 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2014-01-20 00:27:36 PST 
Comment on attachment 221126 [details]
Patch

Rejecting attachment 221126 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 221126, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
html
patching file LayoutTests/fast/multicol/newmulticol/breaks-3-columns-3-expected.html
patching file LayoutTests/fast/multicol/newmulticol/breaks-3-columns-3.html
patching file LayoutTests/fast/multicol/newmulticol/fixed-height-fill-balance-2-expected.html
patching file LayoutTests/fast/multicol/newmulticol/fixed-height-fill-balance-2.html

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'David Hyatt']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/6444814115536896
Comment 7 Morten Stenshorne 2014-01-20 00:59:52 PST 
Created attachment 221630 [details]
Patch
Comment 8 Morten Stenshorne 2014-01-20 01:16:13 PST 
Created attachment 221632 [details]
Patch
Comment 9 Dave Hyatt 2014-01-20 11:34:10 PST 
Comment on attachment 221632 [details]
Patch

r=me
Comment 10 WebKit Commit Bot 2014-01-20 11:51:38 PST 
Comment on attachment 221632 [details]
Patch

Clearing flags on attachment: 221632

Committed r162366: <http://trac.webkit.org/changeset/162366>
Comment 11 WebKit Commit Bot 2014-01-20 11:51:41 PST 
All reviewed patches have been landed.  Closing bug.