Bug 123985 - [EFL] Layout tests with vertical texts need to be rebaselined
Summary: [EFL] Layout tests with vertical texts need to be rebaselined
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-07 03:16 PST by Denis Nomiyama (dnomi)
Modified: 2013-11-07 21:50 PST (History)
5 users (show)

See Also:


Attachments
Patch (771.62 KB, patch)
2013-11-07 21:16 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Nomiyama (dnomi) 2013-11-07 03:16:25 PST
Once the patch from Bug 50619 lands, some layout tests that uses vertical texts will need to be rebaselined.

Here is the list.

editing/selection/vertical-lr-ltr-extend-line-backward-br.html
editing/selection/vertical-lr-ltr-extend-line-forward-br.html
editing/selection/vertical-rl-ltr-extend-line-backward-br.html
editing/selection/vertical-rl-ltr-extend-line-backward-p.html
editing/selection/vertical-rl-ltr-extend-line-backward-wrap.html
editing/selection/vertical-rl-ltr-extend-line-forward-br.html
editing/selection/vertical-rl-ltr-extend-line-forward-p.html
editing/selection/vertical-rl-ltr-extend-line-forward-wrap.html
fast/block/lineboxcontain/block-with-ideographs.xhtml
fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic.html
fast/dynamic/text-combine.html
fast/html/details-writing-mode.html
fast/repaint/japanese-rl-selection-clear.html
fast/repaint/japanese-rl-selection-repaint-in-regions.html
fast/repaint/japanese-rl-selection-repaint.html
fast/repaint/repaint-across-writing-mode-boundary.html
fast/ruby/base-shorter-than-text.html
fast/text/decorations-with-text-combine.html
fast/text/emphasis-combined-text.html
fast/text/emphasis-vertical.html
fast/text/international/text-combine-image-test.html
fast/text/international/text-spliced-font.html
fast/text/international/vertical-text-glyph-test.html
fast/text/justify-ideograph-vertical.html
fast/text/orientation-sideways.html
fast/writing-mode/Kusa-Makura-background-canvas.html
fast/writing-mode/border-vertical-lr.html
fast/writing-mode/broken-ideograph-small-caps.html
fast/writing-mode/broken-ideographic-font.html
fast/writing-mode/fallback-orientation.html
fast/writing-mode/japanese-lr-selection.html
fast/writing-mode/japanese-lr-text.html
fast/writing-mode/japanese-rl-selection.html
fast/writing-mode/japanese-rl-text-with-broken-font.html
fast/writing-mode/japanese-rl-text.html
fast/writing-mode/japanese-ruby-vertical-lr.html
fast/writing-mode/japanese-ruby-vertical-rl.html
fast/writing-mode/text-orientation-basic.html
fast/writing-mode/vertical-align-table-baseline.html
fast/writing-mode/vertical-baseline-alignment.html
fast/writing-mode/vertical-font-fallback.html
Comment 1 Mario Sanchez Prada 2013-11-07 07:20:26 PST
(In reply to comment #0)
> Once the patch from Bug 50619 lands, some layout tests that uses vertical texts 
> will need to be rebaselined.
>
It's done:
http://trac.webkit.org/changeset/158848

Let's keep an eye on the bots now and rebaseline EFL expectations as needed (ping Gyuyoung)
Comment 2 Denis Nomiyama (dnomi) 2013-11-07 10:32:01 PST
According to WebKit console, the patch didn’t break the GTK+ port and some tests are now failing on the EFL port as expected.
So it is safe to rebaseline the tests on EFL.
Comment 3 Gyuyoung Kim 2013-11-07 21:16:54 PST
Created attachment 216358 [details]
Patch
Comment 4 WebKit Commit Bot 2013-11-07 21:50:13 PST
Comment on attachment 216358 [details]
Patch

Clearing flags on attachment: 216358

Committed r158905: <http://trac.webkit.org/changeset/158905>
Comment 5 WebKit Commit Bot 2013-11-07 21:50:16 PST
All reviewed patches have been landed.  Closing bug.