Bug 123984 - [AX] Generate toAccessibilityTableRow|Column|Cell to detect bad type casts
Summary: [AX] Generate toAccessibilityTableRow|Column|Cell to detect bad type casts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-11-07 03:16 PST by Gyuyoung Kim
Modified: 2013-11-07 21:19 PST (History)
10 users (show)

See Also:

Attachments
Patch (15.75 KB, patch)
2013-11-07 03:18 PST, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-11-07 03:16:13 PST 
As a step to let static_cast<> use TYPE_CASTS_BASE, AccessibilityTableRow|Column|Cell use ACCESSIBILITY_OBJECT_TYPE_CASTS which can support more helper functions rather than manual static_cast<>. This change will help to detect bad type casts further.
Comment 1 Radar WebKit Bug Importer 2013-11-07 03:17:07 PST 
<rdar://problem/15412825>
Comment 2 Gyuyoung Kim 2013-11-07 03:18:30 PST 
Created attachment 216284 [details]
Patch
Comment 3 Gyuyoung Kim 2013-11-07 04:15:51 PST 
Mario, how about this ?
Comment 4 Mario Sanchez Prada 2013-11-07 05:54:37 PST 
Comment on attachment 216284 [details]
Patch

(In reply to comment #3)
> Mario, how about this ?

Sounds good to me too :)
Comment 5 WebKit Commit Bot 2013-11-07 21:19:32 PST 
Comment on attachment 216284 [details]
Patch

Clearing flags on attachment: 216284

Committed r158902: <http://trac.webkit.org/changeset/158902>
Comment 6 WebKit Commit Bot 2013-11-07 21:19:35 PST 
All reviewed patches have been landed.  Closing bug.