Bug 123973 – nextBoundary and previousBoundary are very slow when there is a password field

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ryosuke Niwa]

Merge https://chromium.googlesource.com/chromium/blink/+/57366eec5e3edea54062d4e74c0e047f8681dbad

When iterating through DOM nodes nextBoundary and previousBoundary
convert the contents of nodes using text security to a sequence of 'x'
characters. The SimplifiedBackwardsTextIterator and TextIterator may
iterate past node boundaries. Before this patch, the transformation was
done looking at the starting node rather than the current node. In some
situations, this replaced all boundaries with 'x' and caused the
iterator to continue iterating and transforming until the extent of the
document.

[Ryosuke Niwa]

Created attachment 216273 [details]
Fixes the bug

[Martin Robinson]

I had considered posting this patch a few weeks ago, but couldn't figure out how to reproduce the bug in WebKit. I think the fix is valid regardless.

[Alexey Proskuryakov]

Does this address bug 79815 by any chance?

[Martin Robinson]

(In reply to comment #3)
> Does this address bug 79815 by any chance?

That is the test case I was using to test this patch, but I found that even without the patch, the test case shows no sluggish behavior. Can one of you verify that the test case still shows the issue on Mac?

[Alexey Proskuryakov]

There was an observable delay when deleting the last character in password field, using Safari 7 and its included WebKit. I didn't try a nightly.

[Martin Robinson]

(In reply to comment #5)
> There was an observable delay when deleting the last character in password field, using Safari 7 and its included WebKit. I didn't try a nightly.

If this patch fixes that, I say go for it. There may be something peculiar about the GTK+ port that means it doesn't affect us.

[WebKit Commit Bot]

Comment on attachment 216273 [details]
Fixes the bug

Clearing flags on attachment: 216273

Committed r159619: <http://trac.webkit.org/changeset/159619>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

The editing/deleting/password-delete-performance.html test is timing out on bots. 

http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=editing%2Fdeleting%2Fpassword-delete-performance.html

[Alexey Proskuryakov]

*** Bug 79815 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

Ryosuke, could you please fix the test? Tracked as bug 124781 now.

[Ryosuke Niwa]

(In reply to comment #11)
> Ryosuke, could you please fix the test? Tracked as bug 124781 now.

We should just remove the test.