Bug 123969 - Build is broken for architectures with 4 argument registers since r158820
Summary: Build is broken for architectures with 4 argument registers since r158820
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-07 00:34 PST by Julien Brianceau
Modified: 2013-11-07 02:00 PST (History)
7 users (show)

See Also:


Attachments
Build fix (2.58 KB, patch)
2013-11-07 00:40 PST, Julien Brianceau
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-11-07 00:34:31 PST
In jit/CCallHelpers:
- void setupArguments(GPRReg arg1, GPRReg arg2, TrustedImmPtr arg3, TrustedImm32 arg4, GPRReg arg5, GPRReg arg6) is missing
- function using GPRInfo::argumentGPR4 must be under #if NUMBER_OF_ARGUMENT_REGISTERS >= 5 condition
Comment 1 Julien Brianceau 2013-11-07 00:40:48 PST
Created attachment 216269 [details]
Build fix

- add void setupArguments(GPRReg arg1, GPRReg arg2, TrustedImmPtr arg3, TrustedImm32 arg4, GPRReg arg5, GPRReg arg6) for architectures having NUMBER_OF_ARGUMENT_REGISTERS == 4 
- move function using GPRInfo::argumentGPR4 under #if NUMBER_OF_ARGUMENT_REGISTERS >= 5 condition
Comment 2 WebKit Commit Bot 2013-11-07 02:00:42 PST
Comment on attachment 216269 [details]
Build fix

Clearing flags on attachment: 216269

Committed r158830: <http://trac.webkit.org/changeset/158830>
Comment 3 WebKit Commit Bot 2013-11-07 02:00:44 PST
All reviewed patches have been landed.  Closing bug.