RESOLVED FIXED 123966
[SVG] Remove a couple of redundant hashmap look-ups 
https://bugs.webkit.org/show_bug.cgi?id=123966
Summary [SVG] Remove a couple of redundant hashmap look-ups
Ryosuke Niwa
Reported 2013-11-07 00:22:11 PST
Consider merging https://chromium.googlesource.com/chromium/blink/+/b4646c0bed3266b27c6bbdd3c0f47c456bde420f No need for a separate contains() check - HashMap remove/take can handle missing elements just fine. I suspect their SVG code might have diverged enough from our code though.
Attachments
Add attachment proposed patch, testcase, etc.
Adenilson Cavalcanti Silva
Comment 1 2014-09-04 11:53:49 PDT
Just checked WebKit trunk today and both SVGImageCache::removeClientFromCache() and SVGResourcesCache::removeResourcesFromRenderer() no longer have a check for the removed object in the hashmap. It will just go ahead and execute a 'remove()' call. Perhaps the bug can be closed?
Brent Fulgham
Comment 2 2016-03-22 14:06:56 PDT
Closing based on review comments.
Note You need to log in before you can comment on or make changes to this bug.