Bug 123966 - [SVG] Remove a couple of redundant hashmap look-ups
Summary: [SVG] Remove a couple of redundant hashmap look-ups
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-11-07 00:22 PST by Ryosuke Niwa
Modified: 2016-03-22 14:06 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-11-07 00:22:11 PST 
Consider merging https://chromium.googlesource.com/chromium/blink/+/b4646c0bed3266b27c6bbdd3c0f47c456bde420f

No need for a separate contains() check - HashMap remove/take can handle
missing elements just fine.

I suspect their SVG code might have diverged enough from our code though.
Comment 1 Adenilson Cavalcanti Silva 2014-09-04 11:53:49 PDT 
Just checked WebKit trunk today and both SVGImageCache::removeClientFromCache() and SVGResourcesCache::removeResourcesFromRenderer() no longer have a check for the removed object in the hashmap. It will just go ahead and execute a 'remove()' call.

Perhaps the bug can be closed?
Comment 2 Brent Fulgham 2016-03-22 14:06:56 PDT 
Closing based on review comments.