WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
123962
DOMTokenList::add can add duplicated values if arguments had duplicated values
https://bugs.webkit.org/show_bug.cgi?id=123962
Summary
DOMTokenList::add can add duplicated values if arguments had duplicated values
Ryosuke Niwa
Reported
2013-11-06 23:44:15 PST
DOMTokenList::add(const Vector<String>& tokens, ExceptionCode& ec) ensures that newly added tokens are unique existing the existing tokens but don't ensure that newly added tokens are themselves unique. e.g. element.classList.add('a b a') results in element.className being 'a b a' instead of 'a b'.
Attachments
Fixes the bug
(4.25 KB, patch)
2013-11-06 23:47 PST
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2013-11-06 23:44:36 PST
Merge
https://chromium.googlesource.com/chromium/blink/+/bd3822ad4ae3fc5d8f89f433a7bf04f697334305
Ryosuke Niwa
Comment 2
2013-11-06 23:47:35 PST
Created
attachment 216264
[details]
Fixes the bug
WebKit Commit Bot
Comment 3
2013-11-07 15:14:27 PST
Comment on
attachment 216264
[details]
Fixes the bug Clearing flags on attachment: 216264 Committed
r158877
: <
http://trac.webkit.org/changeset/158877
>
WebKit Commit Bot
Comment 4
2013-11-07 15:14:30 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug