WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
123960
Bidi-Isolate inlines break layout with collapsed whitespace
https://bugs.webkit.org/show_bug.cgi?id=123960
Summary
Bidi-Isolate inlines break layout with collapsed whitespace
Ryosuke Niwa
Reported
2013-11-06 23:12:10 PST
Consider merging
https://chromium.googlesource.com/chromium/blink/+/d1cf2bc1fb535d697d9060d9f8d5aa5906558ceb
Collapsed space never worked properly if we have spaces inside and/or after a Bidi-isolate. The problem happens in two parts of the code: 1. The midpointState is not updated properly in addFakeRunIfNecessary. So when an isolated run is added the next midpoint state is wrong. 2. Since isolated runs have a two pass algorithm. In the second pass the midpoint state is wrong. This patches fixes the first problem implementing a method called adjustMidpointsAndAppendRunsForObjectIfNeeded, when a fake run is added it basically updates the midpointState properly. And the second problem is fixed saving and restoring the midpointState for Bidi-isolate inlines.
Attachments
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2013-12-03 19:34:15 PST
Reverted in
https://chromium.googlesource.com/chromium/blink/+/5a81d521ccf169d1448563179f13ffc92a546984
Igor Trindade Oliveira
Comment 2
2013-12-03 22:04:35 PST
recommitted again in:
https://src.chromium.org/viewvc/blink?revision=160400&view=revision
Ryosuke Niwa
Comment 3
2013-12-16 14:32:08 PST
(In reply to
comment #2
)
> recommitted again in:
https://src.chromium.org/viewvc/blink?revision=160400&view=revision
Thanks.
https://chromium.googlesource.com/chromium/blink/+/4bb673d71bb1b4dab0331b09e56d293804e761e3
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug