Bug 123951 – REGRESSION(r72796): Click on focused link removes focus

• Status: NEW
• Component: UI Events

[Ryosuke Niwa]

Enable "Press Tab to hightlight each item on a webpage" on Advanced tab on the Preference

Reproduction steps:
1. Open data:text/html,<input autofocus><a href="#start" onclick="return false">Link</a>
2. Press TAB key once
3. Click on the focused link

Expected result: The link keeps focus.
Actual result: The link looses focus.

http://crbug.com/264575

[Ryosuke Niwa]

Merge http://src.chromium.org/viewvc/blink?revision=155083&view=revision
and
https://chromium.googlesource.com/chromium/blink/+/ddc4ceaa0bd0bd6472844a43c300dcedb8135355

[Kent Tamura]

(In reply to comment #1)
> Merge http://src.chromium.org/viewvc/blink?revision=155083&view=revision
> and
> https://chromium.googlesource.com/chromium/blink/+/ddc4ceaa0bd0bd6472844a43c300dcedb8135355

Yeah, I recommend to merge them at once.

[Ahmad Saleem]

In EventHandler.cpp:

Update here:
https://github.com/WebKit/WebKit/blob/2ef8bf040a9db8c0af836f5a92916e087e9b9e16/Source/WebCore/page/EventHandler.cpp#L2788

and add ASSERT - it is missing currently.

this is already done:

-    bool elementIsMouseFocusable = element && element->isMouseFocusable();

and this as well:

https://github.com/WebKit/WebKit/blob/2ef8bf040a9db8c0af836f5a92916e087e9b9e16/Source/WebCore/page/EventHandler.cpp#L2804

and this is different from Blink patch:

https://github.com/WebKit/WebKit/blob/2ef8bf040a9db8c0af836f5a92916e087e9b9e16/Source/WebCore/page/EventHandler.cpp#L2816

__________

It might not be simple merge.. at least for me..