Bug 123947 - [Efl] Disable LTO when building cairo
Summary: [Efl] Disable LTO when building cairo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nick Diego Yamane (diegoyam)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-06 18:10 PST by Nick Diego Yamane (diegoyam)
Modified: 2013-11-07 04:44 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.45 KB, patch)
2013-11-06 18:12 PST, Nick Diego Yamane (diegoyam)
no flags Details | Formatted Diff | Diff
Patch (1.45 KB, patch)
2013-11-07 03:56 PST, Nick Diego Yamane (diegoyam)
no flags Details | Formatted Diff | Diff
Improved changelog description (1.65 KB, patch)
2013-11-07 04:12 PST, Nick Diego Yamane (diegoyam)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Diego Yamane (diegoyam) 2013-11-06 18:10:03 PST
[Efl] Disable LTO when builing cairo
Comment 1 Nick Diego Yamane (diegoyam) 2013-11-06 18:12:26 PST
Created attachment 216253 [details]
Patch
Comment 2 Laszlo Gombos 2013-11-06 20:31:47 PST
Should we consider a similar change for the gtk port as well ?
Comment 3 Gyuyoung Kim 2013-11-06 21:17:36 PST
(In reply to comment #2)
> Should we consider a similar change for the gtk port as well ?

+1. It would be good to fix gtk port as well.
Comment 4 Nick Diego Yamane (diegoyam) 2013-11-06 21:48:45 PST
(In reply to comment #3)
> (In reply to comment #2)
> > Should we consider a similar change for the gtk port as well ?
> 
> +1. It would be good to fix gtk port as well.

Ok. I'll send a similar patch to fix that in gtk.
Comment 5 Nick Diego Yamane (diegoyam) 2013-11-06 22:06:35 PST
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Should we consider a similar change for the gtk port as well ?
> > 
> > +1. It would be good to fix gtk port as well.
> 
> Ok. I'll send a similar patch to fix that in gtk.

https://bugs.webkit.org/show_bug.cgi?id=123954
Comment 6 Nick Diego Yamane (diegoyam) 2013-11-07 03:56:27 PST
Created attachment 216287 [details]
Patch
Comment 7 Gyuyoung Kim 2013-11-07 03:57:19 PST
Comment on attachment 216253 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216253&action=review

> Tools/ChangeLog:8
> +        - See: https://bugs.freedesktop.org/show_bug.cgi?id=60852

It seems to me patch description is not WebKit style. Please re-write description according to previous WebKit description.
Comment 8 Nick Diego Yamane (diegoyam) 2013-11-07 04:12:25 PST
Created attachment 216288 [details]
Improved changelog description
Comment 9 WebKit Commit Bot 2013-11-07 04:44:34 PST
Comment on attachment 216288 [details]
Improved changelog description

Clearing flags on attachment: 216288

Committed r158845: <http://trac.webkit.org/changeset/158845>
Comment 10 WebKit Commit Bot 2013-11-07 04:44:38 PST
All reviewed patches have been landed.  Closing bug.