Bug 123944 - Remote Layer Tree: RemoteLayerBackingStore partial repaint is broken for the tile cache
Summary: Remote Layer Tree: RemoteLayerBackingStore partial repaint is broken for the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-06 17:29 PST by Tim Horton
Modified: 2013-11-08 17:42 PST (History)
5 users (show)

See Also:


Attachments
patch (25.34 KB, patch)
2013-11-07 17:38 PST, Tim Horton
no flags Details | Formatted Diff | Diff
patch (25.42 KB, patch)
2013-11-07 18:09 PST, Tim Horton
buildbot: commit-queue-
Details | Formatted Diff | Diff
accidental SPI (25.42 KB, patch)
2013-11-08 11:25 PST, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-11-06 17:29:37 PST
Because of the way repaint rects work through TileController, we're repainting the whole tile every time.
Comment 1 Tim Horton 2013-11-07 17:38:51 PST
Created attachment 216346 [details]
patch
Comment 2 WebKit Commit Bot 2013-11-07 17:41:29 PST
Attachment 216346 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/platform/graphics/ca/PlatformCALayer.h', u'Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h', u'Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm', u'Source/WebCore/platform/graphics/ca/mac/TileController.mm', u'Source/WebCore/platform/graphics/mac/WebLayer.h', u'Source/WebCore/platform/graphics/mac/WebLayer.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/mac/RemoteLayerBackingStore.h', u'Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm', u'Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.h']" exit_code: 1
Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h:144:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2013-11-07 18:09:02 PST
Created attachment 216349 [details]
patch
Comment 4 Build Bot 2013-11-07 18:39:46 PST
Comment on attachment 216349 [details]
patch

Attachment 216349 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/22778309
Comment 5 Build Bot 2013-11-07 19:13:02 PST
Comment on attachment 216349 [details]
patch

Attachment 216349 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/22538328
Comment 6 Build Bot 2013-11-07 20:08:28 PST
Comment on attachment 216349 [details]
patch

Attachment 216349 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/22598413
Comment 7 Tim Horton 2013-11-08 11:25:50 PST
Created attachment 216416 [details]
accidental SPI
Comment 8 Simon Fraser (smfr) 2013-11-08 17:35:00 PST
Comment on attachment 216416 [details]
accidental SPI

View in context: https://bugs.webkit.org/attachment.cgi?id=216416&action=review

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * platform/graphics/ca/PlatformCALayer.h:

High level summary please!

> Source/WebCore/ChangeLog:30
> +        has at least one layer in it (appending the clip bounds if we don't

one rect?

> Source/WebCore/platform/graphics/mac/WebLayer.mm:112
> +        graphicsContext.clip(rect);

In the one-rect case you're clipping here where you didn't before, but that's probably OK.
Comment 9 Tim Horton 2013-11-08 17:42:16 PST
http://trac.webkit.org/changeset/158982