Bug 123936 - Nothing should return std::unique_ptr<InlineBox>.
Summary: Nothing should return std::unique_ptr<InlineBox>.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2013-11-06 16:17 PST by Andreas Kling
Modified: 2013-11-06 19:28 PST (History)
5 users (show)

See Also:

Patch (5.53 KB, patch)
2013-11-06 16:18 PST, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch (5.72 KB, patch)
2013-11-06 16:19 PST, Andreas Kling
andersca: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-11-06 16:17:25 PST
We have some functions that return owned InlineBox pointers. We don't need to be that generic, they should return InlineElementBoxes.
Comment 1 Andreas Kling 2013-11-06 16:18:01 PST
Created attachment 216237 [details]
Comment 2 Andreas Kling 2013-11-06 16:19:20 PST
Created attachment 216238 [details]
Comment 3 WebKit Commit Bot 2013-11-06 17:42:27 PST
Comment on attachment 216238 [details]

Rejecting attachment 216238 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 216238, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
in the changes.
Patch failed at 0001 Encoded object stream should be sequential
The copy of the patch that failed is found in:

When you have resolved this problem, run "git rebase --continue".
If you prefer to skip this patch, run "git rebase --skip" instead.
To check out the original branch and stop rebasing, run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 123.

Full output: http://webkit-queues.appspot.com/results/22638044
Comment 4 Andreas Kling 2013-11-06 19:28:21 PST
Committed r158811: <http://trac.webkit.org/changeset/158811>