Bug 123934 - [CSS Shapes] Image shape-outside with vertical gaps is handled incorrectly
Summary: [CSS Shapes] Image shape-outside with vertical gaps is handled incorrectly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on:
Blocks: 116348
  Show dependency tree / graph
 
Reported: 2013-11-06 15:25 PST by Hans Muller
Modified: 2013-11-07 19:48 PST (History)
5 users (show)

See Also:

Attachments
Test case. (841 bytes, text/html)
2013-11-06 15:25 PST, Hans Muller 		no flags Details
Patch (4.22 KB, patch)
2013-11-06 16:51 PST, Hans Muller 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2013-11-06 15:25:00 PST 
Created attachment 216233 [details]
Test case.

When a line overlaps a shape-outside image that contains a vertical gap it's incorrectly laid out as if there's no overlap at all.

The attached test case demonstrates this.
Comment 1 Hans Muller 2013-11-06 16:51:54 PST 
Created attachment 216242 [details]
Patch

RasterShapeIntervals::getExcludedIntervals() was returning an empty list when the line overlapped any vertical gap in the image. This short-circuit had been mistakenly copied from getIncludedIntervals(), where it makes sense.
Comment 2 Andreas Kling 2013-11-07 18:31:38 PST 
Comment on attachment 216242 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2013-11-07 19:48:53 PST 
Comment on attachment 216242 [details]
Patch

Clearing flags on attachment: 216242

Committed r158898: <http://trac.webkit.org/changeset/158898>
Comment 4 WebKit Commit Bot 2013-11-07 19:48:54 PST 
All reviewed patches have been landed.  Closing bug.