Bug 123930 - Move allowed classes handling to decodeObject
Summary: Move allowed classes handling to decodeObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-06 14:47 PST by Anders Carlsson
Modified: 2013-11-06 15:02 PST (History)
0 users

See Also:

Attachments
Patch (3.58 KB, patch)
2013-11-06 14:51 PST, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-11-06 14:47:46 PST 
Move allowed classes handling to decodeObject
Comment 1 Anders Carlsson 2013-11-06 14:51:46 PST 
Created attachment 216227 [details]
Patch
Comment 2 Andreas Kling 2013-11-06 14:56:22 PST 
Comment on attachment 216227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216227&action=review

r=me

> Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm:453
> +    if (!allowedClasses)
> +        allowedClasses = decoder->_allowedClasses;

Not a fan of overwriting arguments like this. I like your IRC version better.
Comment 3 Anders Carlsson 2013-11-06 15:02:44 PST 
Committed r158797: <http://trac.webkit.org/changeset/158797>