Bug 123921 – Web Inspector: ResourceSidebarPanel.prototype.showSourceCode throws an exception when positionToReveal is null

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

The cookie object rise to access positionToReveal when it is allowed to be null.

[Radar WebKit Bug Importer]

<rdar://problem/15407290>

[Timothy Hatcher]

Created attachment 216216 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 216216 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 216216 [details]
Patch

Rejecting attachment 216216 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 216216, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
es to CodeGeneratorInspectorStrings.py should rebuild inspector generated files
The copy of the patch that failed is found in:
   /Volumes/Data/EWS/Webkit/.git/rebase-apply/patch

When you have resolved this problem, run "git rebase --continue".
If you prefer to skip this patch, run "git rebase --skip" instead.
To check out the original branch and stop rebasing, run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 123.

Full output: http://webkit-queues.appspot.com/results/22758015

[WebKit Commit Bot]

Comment on attachment 216216 [details]
Patch

Clearing flags on attachment: 216216

Committed r158816: <http://trac.webkit.org/changeset/158816>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.