Bug 123921 - Web Inspector: ResourceSidebarPanel.prototype.showSourceCode throws an exception when positionToReveal is null
Summary: Web Inspector: ResourceSidebarPanel.prototype.showSourceCode throws an except...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
Keywords: InRadar
Depends on:
Reported: 2013-11-06 13:36 PST by Timothy Hatcher
Modified: 2013-11-06 19:47 PST (History)
5 users (show)

See Also:

Patch (1.53 KB, patch)
2013-11-06 13:38 PST, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-11-06 13:36:55 PST
The cookie object rise to access positionToReveal when it is allowed to be null.
Comment 1 Radar WebKit Bug Importer 2013-11-06 13:37:20 PST
Comment 2 Timothy Hatcher 2013-11-06 13:38:07 PST
Created attachment 216216 [details]
Comment 3 Joseph Pecoraro 2013-11-06 14:45:26 PST
Comment on attachment 216216 [details]

Comment 4 WebKit Commit Bot 2013-11-06 15:09:21 PST
Comment on attachment 216216 [details]

Rejecting attachment 216216 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 216216, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
es to CodeGeneratorInspectorStrings.py should rebuild inspector generated files
The copy of the patch that failed is found in:

When you have resolved this problem, run "git rebase --continue".
If you prefer to skip this patch, run "git rebase --skip" instead.
To check out the original branch and stop rebasing, run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 123.

Full output: http://webkit-queues.appspot.com/results/22758015
Comment 5 WebKit Commit Bot 2013-11-06 19:47:45 PST
Comment on attachment 216216 [details]

Clearing flags on attachment: 216216

Committed r158816: <http://trac.webkit.org/changeset/158816>
Comment 6 WebKit Commit Bot 2013-11-06 19:47:47 PST
All reviewed patches have been landed.  Closing bug.