Bug 123904 - Add WKBrowsingContextPolicyDelegate
Summary: Add WKBrowsingContextPolicyDelegate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-06 11:20 PST by Sam Weinig
Modified: 2013-11-06 11:40 PST (History)
0 users

See Also:

Attachments
Patch (17.32 KB, patch)
2013-11-06 11:23 PST, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-11-06 11:20:49 PST 
Add WKBrowsingContextPolicyDelegate
Comment 1 Sam Weinig 2013-11-06 11:23:01 PST 
Created attachment 216197 [details]
Patch
Comment 2 Anders Carlsson 2013-11-06 11:26:47 PST 
Comment on attachment 216197 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216197&action=review

> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h:46
> +@property (assign) id<WKBrowsingContextLoadDelegate> loadDelegate;
> +@property (assign) id<WKBrowsingContextPolicyDelegate> policyDelegate;

Space after id

> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm:608
> +                WKActionIsMainFrameKey: WKFrameIsMainFrame(frame) ? @YES : @NO,

Can just do @(WKFrameIsMainFrame(frame))

> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm:624
> +                WKActionIsMainFrameKey: WKFrameIsMainFrame(frame) ? @YES : @NO,

Can just do @(WKFrameIsMainFrame(frame))

> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:36
> +extern NSString *WKActionIsMainFrameKey; // NSNumber (BOOL)
> +extern NSString *WKActionNavigationTypeKey; // NSNumber (WKNavigationType)
> +extern NSString *WKActionMouseButtonKey; // NSNumber (0 for left button, 1 for middle button, 2 for right button)
> +extern NSString *WKActionModifierFlagsKey; // NSNumber (unsigned)
> +extern NSString *WKActionURLRequestKey; // NSURLRequest
> +extern NSString *WKActionURLResponseKey; // NSURLResponse
> +extern NSString *WKActionFrameNameKey; // NSString

These should have headerdoc like documentation.
Comment 3 Sam Weinig 2013-11-06 11:40:07 PST 
Committed r158764: <http://trac.webkit.org/changeset/158764>