Bug 123899 – [GTK] Use deprecation guards around deprecated API in GObject DOM bindings

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Carlos Garcia Campos]

Do not include deprecated API when compiling with WEBKIT_DISABLE_DEPRECATED option.

[Carlos Garcia Campos]

Created attachment 216185 [details]
Patch

[Martin Robinson]

Comment on attachment 216185 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216185&action=review

Looking good, with one small nit about the comment style.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1009
> +        push(@hBody, "#endif /* WEBKIT_DISABLE_DEPRECATED */\n");

See below.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1234
> +        push(@cBody, "#endif /* WEBKIT_DISABLE_DEPRECATED */\n");

See below.

> Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:167
> +#endif /* WEBKIT_DISABLE_DEPRECATED */

I think we typically use C++ style comments for this sort of thing.

[Carlos Garcia Campos]

(In reply to comment #2)
> (From update of attachment 216185 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=216185&action=review
> 
> Looking good, with one small nit about the comment style.
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1009
> > +        push(@hBody, "#endif /* WEBKIT_DISABLE_DEPRECATED */\n");
> 
> See below.
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1234
> > +        push(@cBody, "#endif /* WEBKIT_DISABLE_DEPRECATED */\n");
> 
> See below.
> 
> > Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:167
> > +#endif /* WEBKIT_DISABLE_DEPRECATED */
> 
> I think we typically use C++ style comments for this sort of thing.

Yes, that's what I thought, but I checked the feature guards and they all use /* */.

[Martin Robinson]

(In reply to comment #3)

> Yes, that's what I thought, but I checked the feature guards and they all use /* */.

I think this is just an oversight. The bindings are trending toward following the style guidelines over time. :)

[Carlos Garcia Campos]

(In reply to comment #4)
> (In reply to comment #3)
> 
> > Yes, that's what I thought, but I checked the feature guards and they all use /* */.
> 
> I think this is just an oversight. The bindings are trending toward following the style guidelines over time. :)

Yes, I guess, I'll change it before landing then.

[Martin Robinson]

(In reply to comment #5)

> Yes, I guess, I'll change it before landing then.

Cool. Thanks for the patch!

[Carlos Garcia Campos]

(In reply to comment #6)
> (In reply to comment #5)
> 
> > Yes, I guess, I'll change it before landing then.
> 
> Cool. Thanks for the patch!

hmm, is it really ok to use // in public headers that can be included from C code? or do you want me to change only the comments in the cpp file?

[Martin Robinson]

Sorry. Only the CPP code.

[Carlos Garcia Campos]

Committed r158907: <http://trac.webkit.org/changeset/158907>