Bug 123871 - Fix out-of-date offset in selection range code in range.surroundContents
Summary: Fix out-of-date offset in selection range code in range.surroundContents
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Keywords: BlinkMergeCandidate, InRadar
Depends on:
Reported: 2013-11-05 22:19 PST by Ryosuke Niwa
Modified: 2013-11-06 02:53 PST (History)
7 users (show)

See Also:

Merges the fix (4.74 KB, patch)
2013-11-05 22:25 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-11-05 22:19:18 PST
Merge https://chromium.googlesource.com/chromium/blink/+/c89b413ff0fc4aafa0c71d180b0b1e131bb37707

Code in Range::insertNode assumes that the start offset of the selection
range within its container does not change across a call to insertBefore
on the container, which is not true. This patch recomputes the start
offset when it is used after the insertBefore call.
Comment 1 Radar WebKit Bug Importer 2013-11-05 22:19:36 PST
Comment 2 Ryosuke Niwa 2013-11-05 22:25:50 PST
Created attachment 216135 [details]
Merges the fix
Comment 3 WebKit Commit Bot 2013-11-06 02:53:14 PST
Comment on attachment 216135 [details]
Merges the fix

Clearing flags on attachment: 216135

Committed r158738: <http://trac.webkit.org/changeset/158738>
Comment 4 WebKit Commit Bot 2013-11-06 02:53:16 PST
All reviewed patches have been landed.  Closing bug.