WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
123868
Change the order of conditions to avoid computing rendererIsEditable()
https://bugs.webkit.org/show_bug.cgi?id=123868
Summary
Change the order of conditions to avoid computing rendererIsEditable()
Ryosuke Niwa
Reported
2013-11-05 22:06:47 PST
Merge
https://chromium.googlesource.com/chromium/blink/+/c89b413ff0fc4aafa0c71d180b0b1e131bb37707
When we need both Node::renderer() and Node::rendererIsEditable() conditions to be true to perform some operation, it is more effective to check for renderer() first, so that if this condition fails we can avoid unnecessary computation of rendererIsEditable().
Attachments
Merge the cleanup
(2.98 KB, patch)
2013-11-05 22:10 PST
,
Ryosuke Niwa
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2013-11-05 22:10:06 PST
Created
attachment 216132
[details]
Merge the cleanup
Ryosuke Niwa
Comment 2
2013-11-05 22:12:46 PST
Committed
r158723
: <
http://trac.webkit.org/changeset/158723
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug