Bug 123868 - Change the order of conditions to avoid computing rendererIsEditable()
Summary: Change the order of conditions to avoid computing rendererIsEditable()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-11-05 22:06 PST by Ryosuke Niwa
Modified: 2013-11-05 22:12 PST (History)
8 users (show)

See Also:


Attachments
Merge the cleanup (2.98 KB, patch)
2013-11-05 22:10 PST, Ryosuke Niwa
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-11-05 22:06:47 PST
Merge https://chromium.googlesource.com/chromium/blink/+/c89b413ff0fc4aafa0c71d180b0b1e131bb37707

When we need both Node::renderer() and Node::rendererIsEditable()
conditions to be true to perform some operation, it is more effective
to check for renderer() first, so that if this condition fails we can
avoid unnecessary computation of rendererIsEditable().
Comment 1 Ryosuke Niwa 2013-11-05 22:10:06 PST
Created attachment 216132 [details]
Merge the cleanup
Comment 2 Ryosuke Niwa 2013-11-05 22:12:46 PST
Committed r158723: <http://trac.webkit.org/changeset/158723>