Bug 123859 – Remove npr.org specific hack in HTMLMediaElement

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Ryosuke Niwa]

Consider removing the site specific hack added in http://trac.webkit.org/changeset/57820

Blink removed it in https://chromium.googlesource.com/chromium/blink/+/ca27419d2e33d5702db42cdb209db42a5df7d67d

I can no longer reproduce the issue reported in <rdar://problem/7902467> on npr.org

[Eric Carlson]

(In reply to comment #0)
> Consider removing the site specific hack added in http://trac.webkit.org/changeset/57820
> 

The site-specific hack was added in <http://trac.webkit.org/changeset/58586>.

[Eric Carlson]

The hack was added because the npr.org <audio> player had code that called play() when it got a 'canplay' event. The code was essentially:

NPR.StaticEmbedAudio.audio_player.addEventListener('canplay',function() {
    NPR.StaticEmbedAudio.audio_duration=NPR.StaticEmbedAudio.audio_player.duration;
    NPR.StaticEmbedAudio.updateDuration(NPR.StaticEmbedAudio.audio_duration);
    NPR.StaticEmbedAudio.audio_ready=true;
    NPR.StaticEmbedAudio.audio_player.play();
}, true);

The WebKit changes in r57820 caused the 'canplay' event to be fired when the src attribute was set from JS, which caused all <audio> elements on their site to begin playing automatically. The npr.org player has been changed, so we should remove the code added in r58586.

[Ryosuke Niwa]

Yeah, I can't find any video automatically playing on npr.org so it's probably safe to remove it.

[Eric Carlson]

(In reply to comment #3)
> Yeah, I can't find any video automatically playing on npr.org so it's probably safe to remove it.

Only audio played automatically, not video. In any case, I checked their scripts and the code that caused the problem. has been removed.

[Eric Carlson]

Created attachment 216330 [details]
Proposed patch

[Jer Noble]

Comment on attachment 216330 [details]
Proposed patch

r=me

[WebKit Commit Bot]

Comment on attachment 216330 [details]
Proposed patch

Clearing flags on attachment: 216330

Committed r158874: <http://trac.webkit.org/changeset/158874>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.