Bug 123844 - Change ctiTrampoline into a thunk
Summary: Change ctiTrampoline into a thunk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
: 123908 (view as bug list)
Depends on:
Blocks: 116888
  Show dependency tree / graph
 
Reported: 2013-11-05 17:53 PST by Michael Saboff
Modified: 2013-11-20 10:17 PST (History)
6 users (show)

See Also:

Attachments
Patch (59.08 KB, patch)
2013-11-05 18:47 PST, Michael Saboff 		gtk-ews: commit-queue-
Details | Formatted Diff | Diff
Updated with speculative build fixes (66.48 KB, patch)
2013-11-05 21:22 PST, Michael Saboff 		fpizlo: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-11-05 17:53:32 PST 
Given that moving JSC to the C++ stack will require changes to all flavors of ctiTrampoline, it makes sense to convert it and its companion, ctiOpThrowNotCaught, to a thunks.
Comment 1 Michael Saboff 2013-11-05 18:47:42 PST 
Created attachment 216107 [details]
Patch

The changes for ARM traditional, ARM64, MIPS, SH4 and Windows are speculative.  The EWS bots will test some of these.
Comment 2 kov's GTK+ EWS bot 2013-11-05 19:05:12 PST 
Comment on attachment 216107 [details]
Patch

Attachment 216107 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/21248083
Comment 3 Michael Saboff 2013-11-05 21:22:37 PST 
Created attachment 216122 [details]
Updated with speculative build fixes
Comment 4 EFL EWS Bot 2013-11-05 21:40:24 PST 
Comment on attachment 216122 [details]
Updated with speculative build fixes

Attachment 216122 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/21668004
Comment 5 Filip Pizlo 2013-11-06 08:39:44 PST 
Comment on attachment 216122 [details]
Updated with speculative build fixes

Cool!
Comment 6 Michael Saboff 2013-11-06 09:27:58 PST 
Committed r158751: <http://trac.webkit.org/changeset/158751>
Comment 7 Michael Saboff 2013-11-20 10:17:59 PST 
*** Bug 123908 has been marked as a duplicate of this bug. ***