Bug 123837 - [Cocoa] History delegate
Summary: [Cocoa] History delegate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-05 16:30 PST by mitz
Modified: 2013-11-06 14:08 PST (History)
6 users (show)

See Also:

Attachments
Add WKProcessGroupHistoryDelegate and WKNavigationData (40.14 KB, patch)
2013-11-05 16:40 PST, mitz 		no flags Details | Formatted Diff | Diff
Add WKBrowsingContextHistoryDelegate and WKNavigationData (41.91 KB, patch)
2013-11-05 17:28 PST, mitz 		sam: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2013-11-05 16:30:46 PST 
[Cocoa] History delegate
Comment 1 mitz 2013-11-05 16:40:01 PST 
Created attachment 216095 [details]
Add WKProcessGroupHistoryDelegate and WKNavigationData
Comment 2 WebKit Commit Bot 2013-11-05 16:41:43 PST 
Attachment 216095 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/Cocoa/APIObject.mm', u'Source/WebKit2/Shared/Cocoa/WKNSString.h', u'Source/WebKit2/Shared/Cocoa/WKNSURL.h', u'Source/WebKit2/UIProcess/API/C/WKNavigationData.cpp', u'Source/WebKit2/UIProcess/API/C/WKNavigationData.h', u'Source/WebKit2/UIProcess/API/C/WKNavigationDataRef.cpp', u'Source/WebKit2/UIProcess/API/C/WKNavigationDataRef.h', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroup.h', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm', u'Source/WebKit2/UIProcess/Cocoa/WKNavigationData.h', u'Source/WebKit2/UIProcess/Cocoa/WKNavigationData.mm', u'Source/WebKit2/UIProcess/Cocoa/WKNavigationDataInternal.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1
Source/WebKit2/UIProcess/Cocoa/WKNavigationDataInternal.h:34:  More than one command on the same line  [whitespace/newline] [4]
Source/WebKit2/Shared/Cocoa/WKNSString.h:34:  More than one command on the same line  [whitespace/newline] [4]
Source/WebKit2/Shared/Cocoa/WKNSURL.h:34:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 3 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2013-11-05 17:28:43 PST 
Created attachment 216102 [details]
Add WKBrowsingContextHistoryDelegate and WKNavigationData
Comment 4 WebKit Commit Bot 2013-11-05 17:30:11 PST 
Attachment 216102 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/Cocoa/APIObject.mm', u'Source/WebKit2/Shared/Cocoa/WKNSString.h', u'Source/WebKit2/Shared/Cocoa/WKNSURL.h', u'Source/WebKit2/UIProcess/API/C/WKNavigationData.cpp', u'Source/WebKit2/UIProcess/API/C/WKNavigationData.h', u'Source/WebKit2/UIProcess/API/C/WKNavigationDataRef.cpp', u'Source/WebKit2/UIProcess/API/C/WKNavigationDataRef.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm', u'Source/WebKit2/UIProcess/Cocoa/WKBrowsingContextHistoryDelegate.h', u'Source/WebKit2/UIProcess/Cocoa/WKNavigationData.h', u'Source/WebKit2/UIProcess/Cocoa/WKNavigationData.mm', u'Source/WebKit2/UIProcess/Cocoa/WKNavigationDataInternal.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1
Source/WebKit2/UIProcess/Cocoa/WKNavigationDataInternal.h:34:  More than one command on the same line  [whitespace/newline] [4]
Source/WebKit2/Shared/Cocoa/WKNSString.h:34:  More than one command on the same line  [whitespace/newline] [4]
Source/WebKit2/Shared/Cocoa/WKNSURL.h:34:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 3 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 EFL EWS Bot 2013-11-05 17:33:07 PST 
Comment on attachment 216102 [details]
Add WKBrowsingContextHistoryDelegate and WKNavigationData

Attachment 216102 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/21318052
Comment 6 kov's GTK+ EWS bot 2013-11-05 17:43:44 PST 
Comment on attachment 216102 [details]
Add WKBrowsingContextHistoryDelegate and WKNavigationData

Attachment 216102 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/21368047
Comment 7 mitz 2013-11-06 09:34:37 PST 
Committed <http://trac.webkit.org/r158753>.
Comment 8 Sergio Correia (qrwteyrutiyoup) 2013-11-06 14:08:07 PST 
EFL build fix after the WKNavigationData.h => WKNavigationDataRef.h rename:
https://bugs.webkit.org/show_bug.cgi?id=123923