RESOLVED FIXED 123835
Support iteration of the Arguments object 
https://bugs.webkit.org/show_bug.cgi?id=123835
Summary Support iteration of the Arguments object
Oliver Hunt
Reported 2013-11-05 16:17:07 PST
Support iteration of the Arguments object
Attachments
Patch (47.65 KB, patch)
2013-11-05 16:26 PST, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (48.46 KB, patch)
2013-11-05 16:40 PST, Oliver Hunt 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2013-11-05 16:26:46 PST
Created attachment 216094 [details] Patch
EFL EWS Bot
Comment 2 2013-11-05 16:37:48 PST
Comment on attachment 216094 [details] Patch Attachment 216094 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/21248053
Oliver Hunt
Comment 3 2013-11-05 16:40:47 PST
Created attachment 216096 [details] Patch
Mark Lam
Comment 4 2013-11-06 14:20:51 PST
Comment on attachment 216096 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216096&action=review r=me with comments addressed. > Source/JavaScriptCore/runtime/CommonIdentifiers.h:31 > macro(Array) \ > + macro(ArgumentsIterator) \ Sort ArgumentsIterator before Array. > LayoutTests/js/script-tests/arguments-iterator.js:57 > +function testStrict() { > + var i = 0; > + for (arg of arguments) { > + realArg = arguments[i++]; > + shouldBeTrue("arg === realArg"); > + } > + iteratedArgumentsLength = i; > + actualArgumentsLength = arguments.length; > + shouldBe("actualArgumentsLength", "iteratedArgumentsLength"); > +} > + > +testStrict(); > +testStrict("a"); > +testStrict("a", "b"); > +testStrict({}) What makes this test case "strict"? It looks the identical to the non-strict "test()" test case above.
Oliver Hunt
Comment 5 2013-11-06 14:36:06 PST
Committed r158793: <http://trac.webkit.org/changeset/158793>
Note You need to log in before you can comment on or make changes to this bug.